Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct machinectl become plugin function arguments #58734

Merged
merged 5 commits into from Jul 5, 2019
Merged

Correct machinectl become plugin function arguments #58734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca898b3
Correct get_option function name and change flags to become_flags
jb3 Jul 4, 2019
3f27998
Remove the '--' from the returned command
jb3 Jul 4, 2019
5b30fa3
add changelog fragment
jb3 Jul 4, 2019
b57df86
change changelog fragment description
jb3 Jul 4, 2019
51aa6a7
move the -q argument to machinectl before the shell argument to resol…
jb3 Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/58734-correct-machinectl-become-plugin.yaml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- machinectl become plugin - correct bugs which induced errors on plugin usage
6 changes: 3 additions & 3 deletions lib/ansible/plugins/become/machinectl.py
View file
Open in desktop
Expand Up @@ -81,7 +81,7 @@ def build_become_command(self, cmd, shell):
if not cmd:
return cmd

become = self._get_option('become_exe') or self.name
flags = self.get_option('flags') or ''
become = self.get_option('become_exe') or self.name
flags = self.get_option('become_flags') or ''
user = self.get_option('become_user') or ''
return '%s shell -q %s %s@ -- %s' % (become, flags, user, cmd)
return '%s -q shell %s %s@ %s' % (become, flags, user, cmd)