Correct machinectl become plugin function arguments #58734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
felixfontein
suggested changes
Jul 4, 2019
changelogs/fragments/58734-correct-machinectl-become-plugin.yaml
Outdated
Show resolved
Hide resolved
ansibot
added
needs_revision
…ve issues with machinectl v230 (see ansible#56571)
bcoca
approved these changes
Jul 5, 2019
jb3
added a commit
to jb3/ansible
that referenced
this pull request
Jul 5, 2019
* Correct get_option function name and change flags to become_flags * Remove the '--' from the returned command * add changelog fragment * change changelog fragment description * move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see ansible#56571) (cherry picked from commit 4f642da)
abadger
pushed a commit
that referenced
this pull request
Jul 16, 2019
* Correct machinectl become plugin function arguments (#58734) * Correct get_option function name and change flags to become_flags * Remove the '--' from the returned command * add changelog fragment * change changelog fragment description * move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571) (cherry picked from commit 4f642da) * Update PR number in changelog fragment * Revert "Update PR number in changelog fragment" This reverts commit 38e6b47.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request resolves a couple of bugs within the machinectl become plugin introduced when it was moved from the hardcoded setup to the modular setup with ansible 2.8.
_get_optiontoget_optionto prevent anAttributeError.get_optionfrom"flags"to"become_flags"to preventansible.errors.AnsibleError.ISSUE TYPE
COMPONENT NAME
become