Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure recovery services vault modules #58743

Closed
wants to merge 29 commits into from
Closed

azure recovery services vault modules #58743

wants to merge 29 commits into from

Conversation

smile37773
Copy link
Contributor

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_recoveryservicesvault.py
azure_rm_recoveryservicesvault_info.py

@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

cc @haroldwongms @nitzmahone @trstringer @yungezz @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

@smile37773 this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

@smile37773, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 azure cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 5, 2019
@zikalino
Copy link
Contributor

zikalino commented Jul 5, 2019

looks good in general, i think you may start putthing together integration test, in a meanwhile i will add detailed review

@smile37773
Copy link
Contributor Author

looks good in general, i think you may start putthing together integration test, in a meanwhile i will add detailed review
Ok~

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:238:37: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:183:19: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:184:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:188:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:192:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:196:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:200:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:203:23: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:210:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:214:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:217:23: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:222:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:226:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:238:38: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 17 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E326 Argument 'provisioning_state' in argument_spec defines choices as (['Creating', 'Deleting', 'Failed', 'Migrating', 'Succeeded', 'Updating']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E326 Argument 'sku_name' in argument_spec defines choices as (['Standard', 'RS0']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E322 Argument 'append_tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E322 Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'e_tag' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'location' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'provisioning_state' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'sku_name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'type' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'upgrade_details' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E324 Argument 'append_tags' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'append_tags' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'resource_group' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'tags' in argument_spec defines type as 'dict' but documentation doesn't define type

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jul 5, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/azure_rm_recoveryservicesvault/tasks/main.yml:2:37: error syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jul 5, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 5, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Jul 6, 2019
Closed
@Fred-sun
Copy link
Contributor

@smile37773 @zikalino Please update this PR according by comments! Thank you very much!

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:73:22: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E305 DOCUMENTATION.options.upgrade_details.suboptions.status.suboptions.failed.description: required key not provided @ data['options']['upgrade_details']['suboptions']['status']['suboptions']['failed']['description']. Got None
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E305 DOCUMENTATION.options.upgrade_details.suboptions.status.suboptions.in_progress.description: required key not provided @ data['options']['upgrade_details']['suboptions']['status']['suboptions']['in_progress']['description']. Got None
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E305 DOCUMENTATION.options.upgrade_details.suboptions.status.suboptions.unknown.description: required key not provided @ data['options']['upgrade_details']['suboptions']['status']['suboptions']['unknown']['description']. Got None
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E305 DOCUMENTATION.options.upgrade_details.suboptions.status.suboptions.upgraded.description: required key not provided @ data['options']['upgrade_details']['suboptions']['status']['suboptions']['upgraded']['description']. Got None
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E305 DOCUMENTATION.options.upgrade_details.suboptions.trigger_type.suboptions.forced_upgrade.description: required key not provided @ data['options']['upgrade_details']['suboptions']['trigger_type']['suboptions']['forced_upgrade']['description']. Got None
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E305 DOCUMENTATION.options.upgrade_details.suboptions.trigger_type.suboptions.user_triggered.description: required key not provided @ data['options']['upgrade_details']['suboptions']['trigger_type']['suboptions']['user_triggered']['description']. Got None

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 27, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 27, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Sep 4, 2019
@Fred-sun
Copy link
Contributor

@nitzmahone @jborean93 review_need

@Fred-sun
Copy link
Contributor

ping to review

@Fred-sun
Copy link
Contributor

@mybayern1974 @haiyuazhang review_need!

@ansibot
Copy link
Contributor

ansibot commented Dec 21, 2019

cc @gavinfish
click here for bot help

@Fred-sun
Copy link
Contributor

Fred-sun commented Jan 8, 2020

@haiyuazhang @gavinfish @nitzmahone @jborean93

@Fred-sun
Copy link
Contributor

@haiyuazhang @gavinfish @nitzmahone @jborean93 review_need!

@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Mar 6, 2020
@Fred-sun
Copy link
Contributor

@smile37773 Thank you for taking the time to contribute to this PR. We will transfer ansible 's azure module related Issue and PR to azure collection (https://github.com/ansible-collections/azure/pulls), can you transfer the Issue to azure collection repo?

@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Mar 26, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:azure.azcollection support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 29, 2020
@Akasurde
Copy link
Member

Hi @smile37773, Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/azure

If you have further questions please stop by IRC or the mailing list:

* IRC: #ansible on irc.freenode.net
* mailing list: https://groups.google.com/forum/#!forum/ansible-project

needs_info

@Akasurde Akasurde closed this Aug 20, 2020
@ansible ansible locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zikalino zikalino zikalino left review comments

@yungezz yungezz yungezz requested changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 azure cloud collection:azure.azcollection collection Related to Ansible Collections work has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@smile37773 @ansibot @zikalino @samdoran @Fred-sun @Akasurde @yungezz @kpack37