Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure recovery services vault modules #58743

Open
wants to merge 25 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@smile37773
Copy link
Contributor

commented Jul 5, 2019

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_recoveryservicesvault.py
azure_rm_recoveryservicesvault_info.py

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@smile37773 this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@smile37773, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@zikalino

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

looks good in general, i think you may start putthing together integration test, in a meanwhile i will add detailed review

@smile37773

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

looks good in general, i think you may start putthing together integration test, in a meanwhile i will add detailed review
Ok~

@ansibot ansibot removed the needs_triage label Jul 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:238:37: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:183:19: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:184:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:188:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:192:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:196:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:200:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:203:23: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:210:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:214:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:217:23: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:222:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:226:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:238:38: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 17 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E326 Argument 'provisioning_state' in argument_spec defines choices as (['Creating', 'Deleting', 'Failed', 'Migrating', 'Succeeded', 'Updating']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E326 Argument 'sku_name' in argument_spec defines choices as (['Standard', 'RS0']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E322 Argument 'append_tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E322 Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'e_tag' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'location' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'provisioning_state' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'sku_name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'type' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E323 Argument 'upgrade_details' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E324 Argument 'append_tags' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'append_tags' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'resource_group' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:0:0: E337 Argument 'tags' in argument_spec defines type as 'dict' but documentation doesn't define type

click here for bot help

@ansibot ansibot added the ci_verified label Jul 5, 2019

@ansibot ansibot removed the ci_verified label Jul 5, 2019

smile37773 added some commits Jul 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/azure_rm_recoveryservicesvault/tasks/main.yml:2:37: error syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified label Jul 5, 2019

- The current state of the gallery.
type: str
sample: "Succeeded"

This comment has been minimized.

Copy link
@zikalino

zikalino Jul 9, 2019

Contributor

could you check if "upgrade_details" are returned in real scenario?

cloud/azure
shippable/azure/group4
destructive
disabled

This comment has been minimized.

Copy link
@zikalino

zikalino Jul 9, 2019

Contributor

remove "disabled", if it's here test won't run

This comment has been minimized.

Copy link
@zikalino

zikalino Jul 9, 2019

Contributor

also add "azure_rm_recoveryservicesvault_info" in aliases

azure_rm_recoveryservicesvault:
resource_group: "{{ resource_group }}"
name: testVault
sku:

This comment has been minimized.

Copy link
@zikalino

zikalino Jul 9, 2019

Contributor

shouldn't be "sku_name"?

name: Standard
location: "{{ location }}"
register: output

This comment has been minimized.

Copy link
@zikalino

zikalino Jul 9, 2019

Contributor

also run the same task again to check if nothing changes,

and then try to change one of the parameters, I wonder if we can change for instance SKU

smile37773 added some commits Jul 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:101:131: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:80:19: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:80:19: error RETURN: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:80:19: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:80:19: error RETURN: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

fix
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:131:1: E313 RETURN is not valid YAML
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:69:5: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:131:1: error RETURN: syntax error: could not find expected ':'
lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault_info.py:69:5: error RETURN: syntax error: could not find expected ':'

click here for bot help

fix
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:131:1: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_recoveryservicesvault.py:131:1: error RETURN: syntax error: could not find expected ':'

click here for bot help

smile37773 added some commits Jul 9, 2019

fix
fix
fix
fix
fix
@zikalino

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@mattclay could you pls add Microsoft.RecoveryServices?

fix
@samdoran

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@zikalino I can take care of adding that to the account. I am helping out @mattclay so you can ping me with testing related things as well.

@samdoran

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@zikalino I have added Microsoft.RecoverServices

@zikalino

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

thanks @samdoran !

smile37773 added some commits Jul 10, 2019

@ansibot ansibot added the stale_ci label Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.