Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples #58819

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Add examples #58819

merged 2 commits into from
Jul 8, 2019

Conversation

max-cz
Copy link
Contributor

@max-cz max-cz commented Jul 8, 2019

SUMMARY
ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@max-cz
Add examples
6e92ffc 
##### SUMMARY
<!--- Added vlan using aggregate and move vlan interface example -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

cc @justjais @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

@max-cz, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. ios Cisco IOS community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/network/ios/ios_vlan.py:88:1: W293 blank line contains whitespace
lib/ansible/modules/network/ios/ios_vlan.py:100:27: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 8, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jul 8, 2019

Build succeeded (third-party-check pipeline).

max-cz
max-cz commented Jul 8, 2019
View reviewed changes
Copy link
Contributor Author

@max-cz max-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed:
lib/ansible/modules/network/ios/ios_vlan.py:88:1: W293 blank line contains whitespace
lib/ansible/modules/network/ios/ios_vlan.py:100:27: W291 trailing whitespace

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 8, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jul 8, 2019

Build succeeded (third-party-check pipeline).

@acozine
Copy link
Contributor

acozine commented Jul 8, 2019

Thanks @max-cz for enhancing the Ansible documentation with new examples. If you'd like to see these in the "latest" version of the docs, feel free to open a backport PR.

@acozine acozine merged commit 5689cc0 into ansible:devel Jul 8, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 9, 2019
max-cz added a commit to max-cz/ansible that referenced this pull request Jul 10, 2019
@max-cz
Add examples (ansible#58819)
6b0f9c5 
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example

(cherry picked from commit 5689cc0)
acozine pushed a commit that referenced this pull request Jul 10, 2019
@max-cz @acozine
Add examples (#58819) (#58917)
87f0e04 
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example

(cherry picked from commit 5689cc0)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. ios Cisco IOS community module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@max-cz @ansibot @acozine @sivel @dagwieers