New zabbix_service module #58926

emriver · 2019-07-10T13:57:15Z

SUMMARY

New module to manage Zabbix services.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

zabbix_service

ADDITIONAL INFORMATION

Tested on Zabbix 4.0.

* new module zabbix_service * fix type * fix githubid

* new zabbix service module

ansibot · 2019-07-10T14:13:08Z

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E324 Argument 'algorithm' in argument_spec defines default as ('one_child') but documentation defines default as (None)
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E324 Argument 'calculate_sla' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E326 Argument 'algorithm' in argument_spec defines choices as (['no', 'one_child', 'all_childs']) but documentation defines choices as (['False', 'one_child', 'all_childs'])
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:123:1: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_service.py:123:1: error RETURN: syntax error: expected ',' or '}', but got '<stream end>'

click here for bot help

ansibot · 2019-07-10T14:13:09Z

cc @D3DeFi @eikef @rubentsirunyan
click here for bot help

ansibot · 2019-07-10T14:39:34Z

@Akint @D3DeFi @K-dot @RedWhiteMiko @abulimov @akomic @cove @dj-wasabi @eikef @harrisongu @logan2211 @rubentsirunyan @sookido

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

D3DeFi

Tested against Zbx 3.0, 4.0 and 4.2. Works good. Only minor adjustements required.

Btw, do you plan to extend this module to support Service time and service dependencies as well?

D3DeFi · 2019-07-11T08:59:19Z

lib/ansible/modules/monitoring/zabbix/zabbix_service.py

+            - Algorithm used to calculate the sla
+        required: false
+        type: str
+        choices: ["no", "one_child", "all_childs"]


Sorry for being neat-picky, but plural of child is children. Can you change this please? :)

Also it is ideal not to refer to zabbix API documentation very much in module docs, it would be nice if you can add some notes about these choices (["no", "one_child", "all_childs"]) in algorithm description.

Thank you for your review, I have applied your recommendations :)

emriver · 2019-07-11T14:06:03Z

Btw, do you plan to extend this module to support Service time and service dependencies as well?

It is a good idea, but I won't have any time to implement this in the next future.

D3DeFi · 2019-07-11T17:26:31Z

Btw, do you plan to extend this module to support Service time and service dependencies as well?

It is a good idea, but I won't have any time to implement this in the next future.

NP, maybe some day you, me or someone else will find a way to contribute this as a feature :)

D3DeFi

Good work. Tested this
-label needs_triage
shipit

lib/ansible/modules/monitoring/zabbix/zabbix_service.py

Co-Authored-By: sky-joker <megane@kurobuti.com>

D3DeFi

cc @rubentsirunyan

shipit

rubentsirunyan

Looked through the code.
shipit

resmo

Same as #58051, please reimplement the state=dump into a dedicated info module

D3DeFi

LGTM

D3DeFi · 2019-12-13T07:57:08Z

@resmo is this good to go now?

ansibot · 2019-12-13T08:03:05Z

cc @sky-joker
click here for bot help

resmo

LGTM

As a feature request, I would have returned the json of the api response: e.g. the json of the zabbix service created, or the json of the zabbix server deleted. But merge this and work towards.

emriver added 2 commits June 19, 2019 11:04

New module zabbix_service (#5)

fbf245c

* new module zabbix_service * fix type * fix githubid

New Zabbix service module (#11)

2e19701

* new zabbix service module

fix validate module failure

09d7bb0

emriver force-pushed the new_zabbix_service_module branch from 1a55460 to 09d7bb0 Compare July 10, 2019 14:20

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 10, 2019

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 10, 2019

D3DeFi suggested changes Jul 11, 2019

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 11, 2019

Fix algorithm doc and all_childs param name

624be81

D3DeFi approved these changes Jul 11, 2019

View reviewed changes

ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 11, 2019

ansibot added the community_review In order to be merged, this PR must follow the community review workflow. label Jul 11, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 19, 2019

sky-joker reviewed Oct 10, 2019

View reviewed changes

lib/ansible/modules/monitoring/zabbix/zabbix_service.py Outdated Show resolved Hide resolved

Update Ansible version

039ead5

Co-Authored-By: sky-joker <megane@kurobuti.com>

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 11, 2019

D3DeFi approved these changes Oct 14, 2019

View reviewed changes

rubentsirunyan approved these changes Oct 19, 2019

View reviewed changes

ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 19, 2019

resmo suggested changes Oct 19, 2019

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Oct 19, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 27, 2019

remove dump state

7d299f7

emriver force-pushed the new_zabbix_service_module branch from fae750c to 7d299f7 Compare December 10, 2019 10:14

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 10, 2019

D3DeFi approved these changes Dec 10, 2019

View reviewed changes

resmo approved these changes Dec 16, 2019

View reviewed changes

ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2019

resmo merged commit 848782a into ansible:devel Dec 18, 2019

ansible locked and limited conversation to collaborators Jan 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New zabbix_service module #58926

New zabbix_service module #58926

emriver commented Jul 10, 2019

ansibot commented Jul 10, 2019

ansibot commented Jul 10, 2019

ansibot commented Jul 10, 2019

D3DeFi left a comment

D3DeFi Jul 11, 2019

D3DeFi Jul 11, 2019

emriver Jul 11, 2019

emriver commented Jul 11, 2019 •

edited

Loading

D3DeFi commented Jul 11, 2019

D3DeFi left a comment

D3DeFi left a comment

rubentsirunyan left a comment •

edited

Loading

resmo left a comment

D3DeFi left a comment

D3DeFi commented Dec 13, 2019

ansibot commented Dec 13, 2019

resmo left a comment •

edited

Loading

New zabbix_service module #58926

New zabbix_service module #58926

Conversation

emriver commented Jul 10, 2019

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Jul 10, 2019

ansibot commented Jul 10, 2019

ansibot commented Jul 10, 2019

D3DeFi left a comment

Choose a reason for hiding this comment

D3DeFi Jul 11, 2019

Choose a reason for hiding this comment

D3DeFi Jul 11, 2019

Choose a reason for hiding this comment

emriver Jul 11, 2019

Choose a reason for hiding this comment

emriver commented Jul 11, 2019 • edited Loading

D3DeFi commented Jul 11, 2019

D3DeFi left a comment

Choose a reason for hiding this comment

D3DeFi left a comment

Choose a reason for hiding this comment

rubentsirunyan left a comment • edited Loading

Choose a reason for hiding this comment

resmo left a comment

Choose a reason for hiding this comment

D3DeFi left a comment

Choose a reason for hiding this comment

D3DeFi commented Dec 13, 2019

ansibot commented Dec 13, 2019

resmo left a comment • edited Loading

Choose a reason for hiding this comment

emriver commented Jul 11, 2019 •

edited

Loading

rubentsirunyan left a comment •

edited

Loading

resmo left a comment •

edited

Loading