Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New zabbix_service module #58926

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@emriver
Copy link

commented Jul 10, 2019

SUMMARY

New module to manage Zabbix services.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

zabbix_service

ADDITIONAL INFORMATION

Tested on Zabbix 4.0.


emriver added some commits Jun 19, 2019

New module zabbix_service (#5)
* new module zabbix_service

* fix type

* fix githubid
New Zabbix service module (#11)
* new zabbix service module
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E324 Argument 'algorithm' in argument_spec defines default as ('one_child') but documentation defines default as (None)
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E324 Argument 'calculate_sla' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E326 Argument 'algorithm' in argument_spec defines choices as (['no', 'one_child', 'all_childs']) but documentation defines choices as (['False', 'one_child', 'all_childs'])
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/monitoring/zabbix/zabbix_service.py:123:1: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_service.py:123:1: error RETURN: syntax error: expected ',' or '}', but got '<stream end>'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@emriver emriver force-pushed the ovh:new_zabbix_service_module branch from 1a55460 to 09d7bb0 Jul 10, 2019

@ansibot ansibot removed the ci_verified label Jul 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@Akint @D3DeFi @K-DOT @RedWhiteMiko @abulimov @akomic @cove @dj-wasabi @eikef @harrisongu @logan2211 @rubentsirunyan @sookido

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@D3DeFi
Copy link
Contributor

left a comment

Tested against Zbx 3.0, 4.0 and 4.2. Works good. Only minor adjustements required.

Btw, do you plan to extend this module to support Service time and service dependencies as well?

- Algorithm used to calculate the sla
required: false
type: str
choices: ["no", "one_child", "all_childs"]

This comment has been minimized.

Copy link
@D3DeFi

D3DeFi Jul 11, 2019

Contributor

Sorry for being neat-picky, but plural of child is children. Can you change this please? :)

This comment has been minimized.

Copy link
@D3DeFi

D3DeFi Jul 11, 2019

Contributor

Also it is ideal not to refer to zabbix API documentation very much in module docs, it would be nice if you can add some notes about these choices (["no", "one_child", "all_childs"]) in algorithm description.

This comment has been minimized.

Copy link
@emriver

emriver Jul 11, 2019

Author

Thank you for your review, I have applied your recommendations :)

@emriver

This comment has been minimized.

Copy link
Author

commented Jul 11, 2019

Btw, do you plan to extend this module to support Service time and service dependencies as well?

It is a good idea, but I won't have any time to implement this in the next future.

@D3DeFi

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Btw, do you plan to extend this module to support Service time and service dependencies as well?

It is a good idea, but I won't have any time to implement this in the next future.

NP, maybe some day you, me or someone else will find a way to contribute this as a feature :)

@D3DeFi

D3DeFi approved these changes Jul 11, 2019

Copy link
Contributor

left a comment

Good work. Tested this
-label needs_triage
shipit

@ansibot ansibot removed the needs_revision label Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.