Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCS: new module to find vlan(s) based on different criteria #59220

Merged
merged 4 commits into from
Aug 7, 2019
Merged

UCS: new module to find vlan(s) based on different criteria #59220

merged 4 commits into from
Aug 7, 2019

Conversation

dx0xm
Copy link
Contributor

@dx0xm dx0xm commented Jul 18, 2019

SUMMARY

Created to check existing vlan(s) based on a particular criteria. Useful for doing pre checks and maintenance jobs

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ucs_vlan_find

@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

cc @SDBrett @dsoper2 @movinalot @vallard @vvb
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community. ucs Cisco UCS community labels Jul 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:24:0: SyntaxError: Non-ASCII character '\xe2' in file /root/ansible/lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py on line 25, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:24:0: SyntaxError: Non-ASCII character '\xe2' in file /root/ansible/lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py on line 25, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:0:0: E337 Argument 'fabric' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:0:0: E337 Argument 'pattern' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/remote_management/ucs/ucs_vlan_find.py:0:0: E337 Argument 'vlanid' in argument_spec defines type as 'str' but documentation doesn't define type

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2019

@CiscoUcs @SDBrett @dsoper2 @movinalot @SDBrett @sisudhir @vallard @vvb

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 18, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 18, 2019
Akasurde
Akasurde reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit-pick. Rest LGTM

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 26, 2019
@dx0xm
Copy link
Contributor Author

dx0xm commented Aug 6, 2019

Hi @vvb , do you know who can help with this pull request?

Thanks.

dsoper2
dsoper2 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@dsoper2 dsoper2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@Akasurde Akasurde merged commit 24274b7 into ansible:devel Aug 7, 2019
@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

@dsoper2 dsoper2 dsoper2 approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. ucs Cisco UCS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dx0xm @ansibot @Akasurde @dsoper2