Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.8: Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280) #59373

Merged
merged 3 commits into from Jul 23, 2019
Merged

2.8: Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280) #59373

merged 3 commits into from Jul 23, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jul 22, 2019

SUMMARY

This reverts commit 6069d09.

Fixes #57351

(cherry picked from commit b786852)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/vars/manager.py

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 22, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jul 22, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 22, 2019
@abadger abadger merged commit 89d5830 into ansible:stable-2.8 Jul 23, 2019
@abadger
Copy link
Contributor

abadger commented Jul 23, 2019

Merged for the 2.8.3 release.

@mkrizek mkrizek deleted the backport/2.8/59280 branch July 23, 2019 06:50
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 23, 2019
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkrizek @abadger @sivel @ansibot