Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent templating of passwords from prompt (#59246) #59552

Merged
merged 1 commit into from
Aug 7, 2019
Merged

prevent templating of passwords from prompt (#59246) #59552

merged 1 commit into from
Aug 7, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 24, 2019

(cherry picked from commit e9a37f8)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cli

@bcoca
prevent templating of passwords from prompt (ansible#59246)
7138a35 
* prevent templating of passwords from prompt

  fixes CVE-2019-10206

(cherry picked from commit e9a37f8)
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 24, 2019
@abadger
Copy link
Contributor

abadger commented Aug 5, 2019

As talked about on slack, this is blocked until this is applied: https://gist.github.com/abadger/a91c03347fb9a2c0913032917024fa67

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 5, 2019
@abadger
Copy link
Contributor

abadger commented Aug 7, 2019

@jimi-c is going to take care of the change.

@abadger abadger merged commit d39488e into ansible:stable-2.8 Aug 7, 2019
@abadger
Copy link
Contributor

abadger commented Aug 7, 2019

Merged for the 2.8.4 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 8, 2019
@abadger abadger mentioned this pull request Aug 9, 2019
Merged
@abadger
Copy link
Contributor

abadger commented Aug 9, 2019

And jimi-c's PR has been backported and merged now too.

@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoca @abadger @sivel @ansibot