Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ce_vrrp to fix bugs #59677

Merged
merged 4 commits into from
Aug 1, 2019
Merged

Update ce_vrrp to fix bugs #59677

merged 4 commits into from
Aug 1, 2019

Conversation

yanzhangi
Copy link
Contributor

SUMMARY

Manages VRRP interface attributes on HUAWEI CloudEngine devices
When a parameter is of the bool type, for example: If the value is True or yes, an error is reported in the module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_vrrp.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 27, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @numone213 @xuxiaowei0512 @zengchen1024 @zhongjun2
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 27, 2019

@yanzhangi, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Jul 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 27, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @numone213 @xuxiaowei0512 @zengchen1024 @zhongjun2
click here for bot help

yuandongx
yuandongx reviewed Jul 30, 2019
View reviewed changes
lib/ansible/modules/network/cloudengine/ce_vrrp.py
@@ -587,9 +587,9 @@ def check_params(self):
if not self.advertise_interval.isdigit():
self.module.fail_json(
msg='Error: The value of advertise_interval is an integer.')
if int(self.advertise_interval) < 1 or int(self.advertise_interval) > 255000:
if int(self.advertise_interval) < 1000 or int(self.advertise_interval) > 255000:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方的判断仅仅是一个范围可能还不够，它还要求是1000的倍数。
交换机上呈现的是秒，这里是毫秒。

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 30, 2019
@yuandongxx
Copy link
Contributor

+1

yuandongx
yuandongx approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@yuandongx yuandongx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yuandongx
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Aug 1, 2019

Components

lib/ansible/modules/network/cloudengine/ce_vrrp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo numone213 xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): hwDCN xuxiaowei0512
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 1, 2019
@ansibot ansibot merged commit a01ee27 into ansible:devel Aug 1, 2019
@ansible ansible locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuandongx yuandongx yuandongx approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanzhangi @ansibot @yuandongxx @yuandongx