Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.8] Use new version of default test image that contains Python 3.8.0b3(#60139) #60500

Open
wants to merge 1 commit into
base: stable-2.8
from

Conversation

@samdoran
Copy link
Member

commented Aug 13, 2019

SUMMARY

Backport of #60139 for Ansible 2.8
(cherry picked from commit a20848b)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/runner/completion/docker.txt

ADDITIONAL INFORMATION

Depends on #60442
Depends on #60541

[stable-2.8] Use new version of default test image that contains Pyth…
…on 3.8.0b3 (#60139)

(cherry picked from commit a20848b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

The test ansible-test sanity --test shellcheck [explain] failed with 32 errors:

test/integration/targets/blocks/runme.sh:15:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/blocks/runme.sh:23:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/blocks/runme.sh:31:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/blocks/runme.sh:39:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/connection_paramiko_ssh/runme.sh:5:1: SC1091 Not following: ../setup_paramiko/setup.sh was not specified as input (see shellcheck -x).
test/integration/targets/filters/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/group/files/grouplist.sh:19:5: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/groupby_filter/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/handlers/runme.sh:18:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:22:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:26:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:30:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:34:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:38:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:42:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:46:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:49:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:52:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:55:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:79:85: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/include_import/runme.sh:96:9: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/include_import/runme.sh:100:9: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/inventory_aws_conformance/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/inventory_kubevirt_conformance/runme.sh:11:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/inventory_vmware_vm_inventory/runme.sh:63:6: SC2181 Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
test/integration/targets/lookups/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/pull/runme.sh:38:5: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/pull/runme.sh:43:7: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/setup_paramiko/setup.sh:6:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/template_jinja2_latest/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/user/files/userlist.sh:19:5: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/vault/runme.sh:4:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).

click here for bot help

@samdoran

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Re-running tests now that #60442 is merged.

@samdoran

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Looks like we also need to backport c9a9621 which includes some test fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.