Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.8] Use new version of default test image that contains Python 3.8.0b3(#60139) #60500

Merged
merged 1 commit into from
Sep 5, 2019
Merged

[stable-2.8] Use new version of default test image that contains Python 3.8.0b3(#60139) #60500

merged 1 commit into from
Sep 5, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Aug 13, 2019 •
edited
Loading

SUMMARY

Backport of #60139 for Ansible 2.8
(cherry picked from commit a20848b)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/runner/completion/docker.txt

ADDITIONAL INFORMATION

Depends on #60442
Depends on #60541

@samdoran
[stable-2.8] Use new version of default test image that contains Pyth…
8d53b56 
…on 3.8.0b3 (ansible#60139)

(cherry picked from commit a20848b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

The test ansible-test sanity --test shellcheck [explain] failed with 32 errors:

test/integration/targets/blocks/runme.sh:15:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/blocks/runme.sh:23:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/blocks/runme.sh:31:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/blocks/runme.sh:39:52: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/connection_paramiko_ssh/runme.sh:5:1: SC1091 Not following: ../setup_paramiko/setup.sh was not specified as input (see shellcheck -x).
test/integration/targets/filters/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/group/files/grouplist.sh:19:5: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/groupby_filter/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/handlers/runme.sh:18:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:22:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:26:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:30:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:34:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:38:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:42:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:46:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:49:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:52:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:55:3: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/handlers/runme.sh:79:85: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/include_import/runme.sh:96:9: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/include_import/runme.sh:100:9: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/inventory_aws_conformance/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/inventory_kubevirt_conformance/runme.sh:11:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/inventory_vmware_vm_inventory/runme.sh:63:6: SC2181 Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
test/integration/targets/lookups/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/pull/runme.sh:38:5: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/pull/runme.sh:43:7: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/setup_paramiko/setup.sh:6:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/template_jinja2_latest/runme.sh:5:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).
test/integration/targets/user/files/userlist.sh:19:5: SC2196 egrep is non-standard and deprecated. Use grep -E instead.
test/integration/targets/vault/runme.sh:4:1: SC1091 Not following: virtualenv.sh was not specified as input (see shellcheck -x).

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 13, 2019
@samdoran
Copy link
Contributor Author

Re-running tests now that #60442 is merged.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 13, 2019
@samdoran
Copy link
Contributor Author

Looks like we also need to backport c9a9621 which includes some test fixes.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2019
@abadger
Copy link
Contributor

abadger commented Sep 4, 2019

I merged the backport of c9a9621 but it looks like unittests are failing. Will have to check in the morning to see if that's a problem with this PR or with another backport that was merged today.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Sep 4, 2019
@samdoran
Copy link
Contributor Author

samdoran commented Sep 4, 2019

That is really odd. We hit a timeout on some tests and got the failure supposedly fixed by c9a9621. Maybe there are some special cases that need to be fixed in only the stable-2.8 branch.

I am rerunning tests and will investigate.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 4, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 4, 2019
@samdoran
Copy link
Contributor Author

samdoran commented Sep 4, 2019

Looks like I have more work to do on this one.

@samdoran
Copy link
Contributor Author

samdoran commented Sep 4, 2019

We also need do to backport d00aaf6 to stable-2.8. That's why things are failing on this branch.

@samdoran samdoran mentioned this pull request Sep 4, 2019
Merged
@abadger
Copy link
Contributor

abadger commented Sep 4, 2019

Merged the backport of d00aaf6 and told shippable to re-run tests on this PR.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 4, 2019
@abadger abadger merged commit 446df8d into ansible:stable-2.8 Sep 5, 2019
@abadger
Copy link
Contributor

abadger commented Sep 5, 2019

Merged for 2.8.5

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2019
@ansible ansible locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samdoran @ansibot @abadger @sivel