Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hcloud network info #60932

Merged
merged 11 commits into from Aug 21, 2019
Merged

Add hcloud network info #60932

merged 11 commits into from Aug 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2019

SUMMARY

Add hcloud_network_info

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

hcloud_network_info

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:94:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:137:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:138:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:139:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:140:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:141:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:142:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:143:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:144:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:145:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:146:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:147:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:148:21: E122 continuation line missing indentation or outdented

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

cc @LKaemmerling
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud hcloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:94:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:137:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:138:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:139:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:140:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:141:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:142:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:143:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:144:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:145:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:146:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:147:21: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/hcloud/hcloud_network_info.py:148:21: E122 continuation line missing indentation or outdented

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

cc @LKaemmerling
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@LKaemmerling @LKaemmerling

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@LKaemmerling @LKaemmerling

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Aug 21, 2019
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 21, 2019
@LKaemmerling
Apply suggestions from code review
dc1de9a 
Co-Authored-By: Lukas Kämmerling <4281581+LKaemmerling@users.noreply.github.com>
@ghost ghost closed this Aug 21, 2019
@ghost ghost reopened this Aug 21, 2019
@LKaemmerling
Copy link
Contributor

shipit

felixfontein
felixfontein approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2019
@felixfontein
Copy link
Contributor

rebuild_merge

@felixfontein felixfontein reopened this Aug 21, 2019
@felixfontein felixfontein merged commit 4e7cd76 into ansible:devel Aug 21, 2019
@felixfontein
Copy link
Contributor

@cschmitt-hcloud @LKaemmerling thanks for adding this new module!

adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@LKaemmerling @adharshsrivatsr
Add hcloud network info (ansible#60932)
7c02564 
* Add hcloud network facts

* Add tests

* Rename fact to info, adjust tests

* Fix style

* Fix test

* Fix typo

* Adjust test

* Adjust test

* Rename subnets to subnetworks

* Adjustments

* Apply suggestions from code review

Co-Authored-By: Lukas Kämmerling <4281581+LKaemmerling@users.noreply.github.com>
@ansible ansible locked and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud hcloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibot @LKaemmerling @felixfontein