Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

managed_zone documentation update #61080

Closed
wants to merge 3 commits into from
Closed

managed_zone documentation update #61080

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3cc15d
managed_zone documentation update
vince-lessbits Aug 22, 2019
f89a89a
Update lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py
vince-lessbits Aug 23, 2019
2889084
Put the double apostrophe back
vince-lessbits Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@
description:
- Identifies the managed zone addressed by this request.
- 'This field represents a link to a ManagedZone resource in GCP. It can be specified
in two ways. First, you can place a dictionary with key ''name'' and value of
your resource''s name Alternatively, you can add `register: name-of-resource`
in two ways. First, you can place a dictionary with 2 keys: ''name'' and value of
your resource''s name, ''dnsName'' and the value of the DNS name manged by this zone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
your resource''s name, ''dnsName'' and the value of the DNS name manged by this zone
your resource's name, ''dnsName'' and the value of the DNS name managed by this zone

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still need to get rid of the extra ` in resource``s above.

Alternatively, you can add `register: name-of-resource`
to a gcp_dns_managed_zone task and then set this managed_zone field to "{{ name-of-resource
}}"'
required: true
Expand Down