Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routeros_facts: fix for error when there's more than 10 interfaces #62346

Merged
merged 2 commits into from Sep 17, 2019
Merged

routeros_facts: fix for error when there's more than 10 interfaces #62346

merged 2 commits into from Sep 17, 2019

Conversation

heuels
Copy link
Contributor

@heuels heuels commented Sep 16, 2019 •
edited

SUMMARY

This fix has already been merged into devel as fa03f43 (#61376). This is a cherry-pick for stable-2.9 branch.
Fixes #61374.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

routeros_facts

ADDITIONAL INFORMATION

@heuels
routeros_facts: fix for error when there's more than 10 interfaces (a…
b964fea 
…nsible#61376)

* fix: proper regex for preprocessing routeros output

* test: regression test

* test: fix nondeterministic unit test
@heuels
Copy link
Contributor Author

heuels commented Sep 16, 2019

@ganeshrn, here is a cherry-picked fix for the stable-2.9 branch, as promised.

@ansibot
Copy link
Contributor

ansibot commented Sep 16, 2019

cc @NilashishC @Qalthos @danielmellado @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 16, 2019
@abadger
Copy link
Contributor

abadger commented Sep 17, 2019

This change needs a changelog fragment and can be merged once that's added.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 17, 2019
@heuels
Copy link
Contributor Author

heuels commented Sep 17, 2019

@abadger, it's done. Thanks for pointing that out for me!

@abadger abadger merged commit a48f8f2 into ansible:stable-2.9 Sep 17, 2019
@abadger
Copy link
Contributor

abadger commented Sep 17, 2019

Merged for the 2.9.0rc1 release. Thanks!

@heuels heuels deleted the stable-2.9 branch September 18, 2019 09:03
@heuels
Copy link
Contributor Author

heuels commented Sep 18, 2019

@abadger, thank you!

@ansible ansible locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heuels @ansibot @abadger