Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing GcpSession.put definition to accept additional kwargs (#56326) #62493

Closed
wants to merge 1 commit into from
Closed

Fixing GcpSession.put definition to accept additional kwargs (#56326) #62493

wants to merge 1 commit into from

Conversation

rafal-styrylski
Copy link

SUMMARY

Allowing GcpSession.put to accept additional kwargs, similar to other methods.
Fixes #56326

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

GCP

ADDITIONAL INFORMATION

update call in gcp_iam_role.py passes additional arguments to GcpSession.put, resulting in TypeError as seen in #56326

ansible/lib/ansible/modules/cloud/google/gcp_iam_role.py

Line 197 in fd7e156

return return_if_object(module, auth.put(link, request, params=params))

Fix accepts kwargs and passes them to GcpSession.full_put, similar to other methods.

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @erjohnso @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 1, 2019
@nkakouros
Copy link
Contributor

This seems to have been fixed. BTW, I don't think they accept direct modification of the modules. These modules are generated by other core and it is there that fixes should be made against.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 26, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:google.cloud needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@nkakouros
Copy link
Contributor

This PR should be closed.

@rafal-styrylski
Copy link
Author

Closing as requested, thank you for explanation.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 12, 2020
@ansible ansible locked and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. collection:google.cloud collection Related to Ansible Collections work needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcp_iam_role does not work
4 participants
@rafal-styrylski @ansibot @nkakouros @mkrizek