Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include computer_name in VM instance facts #62566

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Include computer_name in VM instance facts #62566

merged 2 commits into from
Sep 20, 2019

Conversation

arvindshmicrosoft
Copy link
Contributor

Implement #62564 by returning the computer name from OS profile

SUMMARY

Fixes #62564 by additionally returning computer_name in VM instance facts

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_virtualmachinescalesetinstance_facts

ADDITIONAL INFORMATION
BEFORE:

            {
                "id": "/subscriptions/.../resourceGroups/.../providers/Microsoft.Compute/virtualMachineScaleSets/somevmss/virtualMachines/7",
                "instance_id": "7",
                "latest_model": true,
                "name": "somevmss_7",
                "power_state": "running",
                "provisioning_state": "Succeeded",
                "resource_group": "...",
                "tags": null,
                "vm_id": "..."
            }


AFTER:
            {
                "computer_name": "somevmss000007",
                "id": "/subscriptions/.../resourceGroups/.../providers/Microsoft.Compute/virtualMachineScaleSets/somevmss/virtualMachines/7",
                "instance_id": "7",
                "latest_model": true,
                "name": "somevmss_7",
                "power_state": "running",
                "provisioning_state": "Succeeded",
                "resource_group": "...",
                "tags": null,
                "vm_id": "..."
            }

Implement #62564 by returning the computer name from OS profile
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2019

@arvindshmicrosoft, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 azure cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 19, 2019
@Fred-sun
Copy link
Contributor

ready_for_review

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2019
@yungezz yungezz merged commit 41bfd2b into ansible:devel Sep 20, 2019
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 azure cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_virtualmachinescalesetinstance_facts should return computer name
4 participants