-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Ansible Tower content for move to AWX collection #62924
Conversation
The test
|
shipit |
The test
The test
The test
|
👍 |
c739da0
to
c8246ad
Compare
The test
The test
The test
|
c8246ad
to
14cf066
Compare
sanity tests passing locally, will check back in for CI results. |
The test
The test
|
I don't think so? But there is a bit of an issue up-in-the-air here. We are using the metadata marker "deprecated", but there is a new one for "migrated_to" (I think, might not be congruent) #63952 That is reflected in some of the conversation here. But that is extremely new, and we have no precedent for using it in a context like this. I don't know if it's okay to use it in a context like this. But I also don't know if the syntax in this PR currently will be preferred. So I'm waiting for direction on that, if there is anything to do. I'm happy to try doing the newest and best thing, if we can get definition about what that is. |
The |
that is new to me looks like it's doing about the same thing as here. But that also happened before any migrated_to option was around. |
b0a6375
to
0018534
Compare
Rename tower module files for deprecation
Update ignore entries
0018534
to
0eefcb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the addition to the botmeta, this looks good. we are moving to do this for modules that have moved out for partners now as well. lgtm shipit
🎉 #67233 🎉 |
SUMMARY
Deprecate this content because it will move to a collection.
ansible/awx#4701
We have not yet released our initial version to awx.awx on Galaxy.
My test releases are at https://galaxy.ansible.com/alancoding/awx
I believe we are fully complete, so we will be pulling the trigger soon (but I want to send out emails, and also have this PR ready when I do)
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/doc_fragments/tower.py
ADDITIONAL INFORMATION
The new collection has been tested with:
https://github.com/bcoca/ansible-minmal
And everything works fine. We are also running the existing integration tests for the current modules with the new collection.
docs tested with: