Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrated_to for tower to awx.awx #67233

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

AlanCoding
Copy link
Member

SUMMARY

Modeled after #65885, want to flag this properly for when migration transition tooling is ran.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

.github/BOTMETA.yml

ADDITIONAL INFORMATION

https://galaxy.ansible.com/awx/awx

Subset of #62924, but thinking this might be closer to the intention given the other PRs that have landed.

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 botmeta This PR modifies the BOTMETA.yml and this requires special attention! core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 8, 2020
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Duebto how the docs build works, we need a migrated_to added explicitly for each file, not just the directory.

Every module, inventory plugin, docs fragment, module utils

See other examples in BOTMETA.yml

@AlanCoding

This comment has been minimized.

@@ -1200,7 +1246,8 @@ files:
$module_utils:
support: community
$module_utils/acme.py: *crypto
$module_utils/ansible_tower.py: *tower
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dropped the *tower, because I was unsure if syntax would keep working if I kept it, and the other entries did not have it. I also don't want to declare things like maintainers, because we are not maintaining it.

@AlanCoding
Copy link
Member Author

Updated to include module_utils, doc_fragment, and inventory plugin.

That should be comprehensive, given the content that we have in the collection itself.

Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gundalow gundalow merged commit 1a45040 into ansible:devel Feb 13, 2020
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2020
@ansible ansible locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 botmeta This PR modifies the BOTMETA.yml and this requires special attention! core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants