-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migrated_to for tower to awx.awx #67233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Duebto how the docs build works, we need a migrated_to
added explicitly for each file, not just the directory.
Every module, inventory plugin, docs fragment, module utils
See other examples in BOTMETA.yml
00b1f5f
to
c77e9dd
Compare
This comment has been minimized.
This comment has been minimized.
c77e9dd
to
87c07aa
Compare
@@ -1200,7 +1246,8 @@ files: | |||
$module_utils: | |||
support: community | |||
$module_utils/acme.py: *crypto | |||
$module_utils/ansible_tower.py: *tower |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dropped the *tower
, because I was unsure if syntax would keep working if I kept it, and the other entries did not have it. I also don't want to declare things like maintainers, because we are not maintaining it.
Updated to include module_utils, doc_fragment, and inventory plugin. That should be comprehensive, given the content that we have in the collection itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SUMMARY
Modeled after #65885, want to flag this properly for when migration transition tooling is ran.
ISSUE TYPE
COMPONENT NAME
.github/BOTMETA.yml
ADDITIONAL INFORMATION
https://galaxy.ansible.com/awx/awx
Subset of #62924, but thinking this might be closer to the intention given the other PRs that have landed.