Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding _prefix rule scopes to consul_acl #62925

Closed
wants to merge 2 commits into from
Closed

Adding _prefix rule scopes to consul_acl #62925

wants to merge 2 commits into from

Conversation

mheiland
Copy link

_prefix rule scopes for ACLs have been added with Consul 1.4

+label: docsite_pr

SUMMARY

With Consul 1.4 a new ACL system has been added, including _prefix rule scopes which allow simpler ACLs with regards to inheritance. I was writing a playbook to setup Consul and some base ACLs and noticed that the consul_acl modules whitelist does not yet support these. Adding valid _prefix rule scopes is fairly trivial and i hope others benefit from it.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

consul_acl

ADDITIONAL INFORMATION

Current Consul ACLs are documented here: https://www.consul.io/docs/acl/acl-rules.html

@mheiland
Adding _prefix rule scopes
ab2d28d 
_prefix rule scopes for ACLs have been added with Consul 1.4 - See: https://www.consul.io/docs/acl/acl-rules.html

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Sep 27, 2019

cc @colin-nolan @sgargan
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 clustering Clustering category community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 27, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/clustering/consul_acl.py:190:161: E501: line too long (214 > 160 characters)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 27, 2019
@mheiland
Cosmetics
f8f2332 
Keeping limit of 160 characters per line
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 28, 2019
@colin-nolan
Copy link
Contributor

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 30, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Oct 1, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 9, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 10, 2019
@Strum355
Copy link

Any chance this PR could have the conflicts resolved and hopefully merged?

@ansibot ansibot removed the new_module This PR includes a new module. label Mar 28, 2020
@ansibot ansibot added the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Mar 28, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md and removed needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bot_closed clustering Clustering category collection:community.general collection Related to Ansible Collections work docsite_pr This PR is created from documentation using the "Edit on GitHub" link. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mheiland @ansibot @colin-nolan @Strum355 @dagwieers