Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry is number of times we try after the first failure #63918

Closed
wants to merge 2 commits into from
Closed

Retry is number of times we try after the first failure #63918

wants to merge 2 commits into from

Conversation

ujwalkomarla
Copy link
Contributor

@ujwalkomarla ujwalkomarla commented Oct 24, 2019 •
edited
Loading

SUMMARY

Fixes #63872 - exos_command: Local variable 'responses' referenced before assignment and the way we use 'retries'.

'Retries' description:

Specifies the number of retries a command should by tried
before it is considered failed. The command is run on the
target device every retry and evaluated against the
I(wait_for) conditions.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

exos_command

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2019

cc @LindsayHill @bigmstone @rdvencioneck
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:206:24: multiple-statements: More than one statement on a single line

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/exos/exos_command.py:206:23: E701: multiple statements on one line (colon)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed owner_pr This PR is made by the module's maintainer. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 24, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 1, 2019
@rohitthakur2590 rohitthakur2590 removed the needs_triage Needs a first human triage before being processed. label Nov 6, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 29, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.network labels Apr 29, 2020
@Akasurde
Copy link
Member

Hi @ujwalkomarla, Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.network

If you have further questions please stop by IRC or the mailing list:

* IRC: #ansible on irc.freenode.net
* mailing list: https://groups.google.com/forum/#!forum/ansible-project

needs_info

@Akasurde Akasurde closed this Aug 20, 2020
@ansible ansible locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. collection:community.network collection Related to Ansible Collections work module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exos_command insta-fail: UnboundLocalError: local variable 'responses' referenced before assignment
4 participants
@ujwalkomarla @ansibot @Akasurde @rohitthakur2590