Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NSG ruler protocol --Icmp #66028

Closed
wants to merge 1 commit into from
Closed

Add NSG ruler protocol --Icmp #66028

wants to merge 1 commit into from

Conversation

Fred-sun
Copy link
Contributor

SUMMARY

Azure securitygroups now support creating rules for the ICMP protocol when creating rules via the Azure portal, So add the ICMP protocol in Ansble.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_securitygroup

ADDITIONAL INFORMATION

@Fred-sun Fred-sun mentioned this pull request Dec 23, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Dec 23, 2019

cc @gavinfish @haiyuazhang @haroldwongms @nitzmahone @yungezz @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 23, 2019

@Fred-sun, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 azure cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 23, 2019
@Fred-sun
Copy link
Contributor Author

ready_for_review

@ansibleazurebot ansibleazurebot mentioned this pull request Dec 23, 2019
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 31, 2019
@Fred-sun
Copy link
Contributor Author

@haiyuazhang @gavinfish

@Fred-sun
Copy link
Contributor Author

Fred-sun commented Feb 5, 2020

ping to reivew!

gavinfish
gavinfish approved these changes Feb 5, 2020
View reviewed changes
Copy link

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 5, 2020
@Fred-sun Fred-sun mentioned this pull request Mar 16, 2020
Merged
@Fred-sun
Copy link
Contributor Author

This PR has been migrated to #68.

@Fred-sun Fred-sun closed this Mar 16, 2020
@ansible ansible locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavinfish gavinfish gavinfish approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 azure cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fred-sun @ansibot @gavinfish