Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snow: Add new parameter 'host' #66184

Closed
wants to merge 1 commit into from
Closed

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jan 4, 2020

SUMMARY

Added support for specifying custom service now domain.

Fixes: #62018

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/62018_snow_host.yml
lib/ansible/module_utils/service_now.py
lib/ansible/modules/notification/snow_record.py
lib/ansible/modules/notification/snow_record_find.py
lib/ansible/plugins/doc_fragments/service_now.py

@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2020

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. notification Notification category support:community This issue/PR relates to code supported by the Ansible community. labels Jan 4, 2020
@ansibot ansibot added has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 6, 2020
Added support for specifying custom service now domain.

Fixes: ansible#62018

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't use this so can't try it manually. would be greate if someone did
shipit

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 6, 2020
@Akasurde
Copy link
Member Author

@garbled1 @n3pjk @jmcleroy @theemptyone Can you please test this PR and let me know if it works for you? Thanks in advance.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 21, 2020
@martbhell
Copy link
Contributor

martbhell commented Feb 5, 2020

Hello, I tested this in #41320 (comment)

It looks OK. But I am mostly interested in the inventory part of service now. Is there something else you would like me to test? I would like to test it without disabling CA verification so that's something I'll have to look into, taking suggestions how to do that, maybe even without updating the system CA bundle?

@Akasurde
Copy link
Member Author

Akasurde commented Mar 3, 2020

Migrated to ServiceNowITOM/servicenow-ansible#5

@Akasurde Akasurde closed this Mar 3, 2020
@Akasurde Akasurde deleted the i62018 branch March 3, 2020 06:58
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 3, 2020
@ansible ansible locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. has_issue module This issue/PR relates to a module. notification Notification category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snow_record (and snow resources in general) should allow for host as well as instance
5 participants