-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: User Guide overhaul, part 3 #66371
Conversation
41dde10
to
81546c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits
|
||
Ansible offers two ways to re-use files and roles in a playbook: dynamic and static. | ||
|
||
- For dynamic re-use, add an ``include_*`` task in the tasks section of a play: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it still an include_*
task if you are including a role or vars? same question for the import_*
below this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't figured out how to express this yet. Any time you use include_*
, that line is, itself, a task. So it's not about what you're including, it's about where/how you're including.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alicia, add my feedback, which was mostly style-related. I did spot an issue with one of the CLI options (-tags
instead of --tags
), but overall it reads well and I understood what your wrote quite clearly.
93364c8
to
ba692f8
Compare
Thanks @samccann @cbudz and @danmacpherson for the detailed reviews! I think I've incorporated all your comments. |
SUMMARY
Related to #65474 and #63056.
Edits more User Guide pages. Main goals include de-duplicating content, organizing content around user goals, helping users find the content they need by providing action-oriented headers, and slimming down the text where possible.
Main changes include:
ISSUE TYPE
COMPONENT NAME
docs.ansible.com
User Guide, Tags, Roles, Includes, Imports