Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set domain_id when domain is set or project/domain is set #66526

Closed
wants to merge 1 commit into from
Closed

Set domain_id when domain is set or project/domain is set #66526

wants to merge 1 commit into from

Conversation

valerytschopp
Copy link

SUMMARY

Fixes #66525

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_user_role

ADDITIONAL INFORMATION
TASK [Assign admin role to user heat_domain_admin_test in domain heat] *******************************************************************************************************
changed: [openstack_s2] => {"changed": true}

@ansibot
Copy link
Contributor

ansibot commented Jan 16, 2020

cc @Shrews @cloudnull @dagnello @emonty @gtema @juliakreger @mnaser @odyssey4me @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Jan 16, 2020
@opendev-zuul
Copy link

opendev-zuul bot commented Jan 16, 2020

Build succeeded (third-party-check pipeline).

@sshnaidm
Copy link
Contributor

Thanks for submitting patch for Openstack Ansible modules!
We moved Openstack Ansible modules to Openstack repositories.
Next patches should be submitted not with Ansible Github but with
Openstack Gerrit: https://review.opendev.org/#/q/project:openstack/ansible-collections-openstack
Please submit your code there from now.
Thanks for your contribution and sorry for inconvienience.

@valerytschopp
Copy link
Author

Hey @sshnaidm
Ok, I can start a gerrit, but before I need to submit the bug in https://bugs.launchpad.net/openstack/+filebug, right? I don't find the ansible-collections-openstack project, so in which openstack project should I submit the bug?

@sshnaidm
Copy link
Contributor

@valerytschopp please use storyboard for bugs: https://storyboard.openstack.org/#!/project/openstack/ansible-collections-openstack

@valerytschopp
Copy link
Author

@sshnaidm like this https://storyboard.openstack.org/#!/story/2007184 ?

@sshnaidm
Copy link
Contributor

@valerytschopp nice done! You can put in commit message in Gerrit "Story: #Number_of_Story", for example "Story: #2006847" like here: https://review.opendev.org/#/c/703381/ and it will link your patch to story.
Please be aware that this week we are in transition, so it may require rebases and reviews will be delayed.

sshnaidm
sshnaidm suggested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we moved Openstack Ansible modules to Openstack repositories, please submit all changes from openstack modules to Openstack Gerrit: https://review.opendev.org/#/q/project:openstack/ansible-collections-openstack Thanks for your contribution and sorry for inconvienience.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 21, 2020
@valerytschopp
Copy link
Author

Story: https://storyboard.openstack.org/#!/story/2007184

Review: https://review.opendev.org/#/c/703428/

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 31, 2020
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 3, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:openstack.cloud needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot ansibot removed collection:openstack.cloud needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Jul 14, 2020
@Akasurde
Copy link
Member

@valerytschopp Thanks for the contribution. Closing as per above.

@Akasurde Akasurde closed this Aug 19, 2020
@ansible ansible locked as resolved and limited conversation to collaborators Aug 19, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sshnaidm sshnaidm sshnaidm requested changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud collection Related to Ansible Collections work module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. openstack stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_user_role: fails to assign role in domain only
5 participants
@valerytschopp @ansibot @sshnaidm @Akasurde @sivel