Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OS_FAMILY_MAP for openEuler OS #67421

Closed
wants to merge 1 commit into from
Closed

Update OS_FAMILY_MAP for openEuler OS #67421

wants to merge 1 commit into from

Conversation

Zhiwei-Dai
Copy link
Contributor

Add support for openEuler OS

Signed-off-by: Dai zhiwei daizhiwei3@huawei.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@Zhiwei-Dai
Update OS_FAMILY_MAP for openEuler OS
8fd3a63 
Add support for openEuler OS

Signed-off-by: Dai zhiwei daizhiwei3@huawei.com
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 14, 2020
@Akasurde
Copy link
Member

@Zhiwei-Dai Thanks for the contribution. Could you please provide the output of Ansible facts before and after? Thanks.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 14, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 22, 2020
@Akasurde Akasurde self-assigned this Feb 25, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 25, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 4, 2020
@Zhiwei-Dai
Copy link
Contributor Author

@Akasurde
Well. Ths for your review. There are some command line output,

[root@test3 ~]# cat /etc/os-release
NAME="openEuler"
VERSION="1.0 ()"
ID="openEuler"
VERSION_ID="1.0"
PRETTY_NAME="openEuler 1.0 ()"
ANSI_COLOR="0;31"

Before the PR,

[root@test3 dcy]# ansible localhost -m setup |grep ansible_os_family
        "ansible_os_family": "openEuler",

After the PR,

[root@test3 dcy]# ansible localhost -m setup |grep ansible_os_family
        "ansible_os_family": "RedHat",

@Akasurde
Copy link
Member

Akasurde commented May 5, 2020

Superseded by #69324

@Akasurde Akasurde closed this May 5, 2020
@ansible ansible locked and limited conversation to collaborators Jun 2, 2020
@Zhiwei-Dai Zhiwei-Dai deleted the patch-1 branch July 2, 2020 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Akasurde Akasurde

Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zhiwei-Dai @Akasurde @samdoran @ansibot