fix extraneous newlines after warnings without breaking ansible runner

[ryanpetrello]

original PR: #65199

I'm not totally sure why, but this change appears to have introduced a regression with ansible runner's display plugin:

ansible/awx#6357

[ryanpetrello]

cc @chrismeyersfsu @matburt @AlanCoding

[ryanpetrello]

@samdoran spoke with me and noted that he'd prefer not to roll back this change, as it addresses a bug. So if I find time, I may try to find another way to address this without regressing on the bug.

[ryanpetrello]

I'm going to see if I can come up with a way to address the ansible bug, but also fix AWX output.

If I can't figure it out, I might need some help from somebody who's more familiar w/ Ansible's callback plugin interface, because this change is making all AWX output look like this (ansible/awx#6357):

[ryanpetrello]

Also affects plain Ansible Runner w/ ansible 2.9.6:

Problem goes away if I downgrade to 2.9.0:

[AlanCoding]

I think best place to start would be writing integration tests in ansible-runner, get fastest feedback that way. There's a lot I need to do there, but I haven't gotten back around to it.

[ryanpetrello]

@samdoran I've pushed up a change that attempts to resolve this by just removing the \n from the warning method instead of moving the color code around like your original PR.

[jctanner]

We're actively testing runner on every commit. What are our tests missing that would have caught this issue?

https://github.com/ansible/ansible/tree/devel/test/integration/targets/ansible-runner/tasks

needs_info

[ryanpetrello]

replaced by #68517

[bcoca]

closing in favor of #68517