UI job logs has excess new line on each tasks

[ryan012880]

ISSUE TYPE

• Bug Report

SUMMARY

In the UI each line in the task job log has an additional newline.

ENVIRONMENT

• AWX version: 9.3.0
• AWX install method: docker on linux
• Ansible version: 2.9.5
• Operating System: RHEL7
• Web Browser: Chrome

STEPS TO REPRODUCE

Launch a JT for multiple targets

EXPECTED RESULTS

ACTUAL RESULTS

ADDITIONAL INFORMATION

Downloading the logs shows

[ryanpetrello]

@ryan012880,

Are you running 9.3.0, or devel (with the new redis changes)?

[ryanpetrello]

I think this might be a change/regression in Ansible itself. Here's a video that shows a difference in behavior between Ansible 2.9.0 and 2.9.6:

http://ryanpetrello.com/ansible-callback-bug.mp4

[ryanpetrello]

Here's what we're getting in Ansible 2.9.6 for a job that exhibits this behavior:

bash-4.4$ cd /tmp/awx_31_ojeomhuq/artifacts/31/
bash-4.4$ pwd
^M
PLAY [Hello World Sample] ******************************************************
^M
TASK [Gathering Facts] *********************************************************
^[[0;32mok: [localhost]^[[0m^M
^[[0;32m^[[
^M
TASK [Hello Message] ***********************************************************
^[[0;32mok: [localhost] => {^[[0m^M
^[[0;32m    "msg": "Hello World!"^[[0m^M
^[[0;32m}^[[0m^M
^[[0;32m^[[
^M
PLAY RECAP *********************************************************************^M
^[[0;32mlocalhost^[[0m                  : ^[[0;32mok=2   ^[[0m changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   ^M

[ryanpetrello]

Here's what we're getting in Ansible 2.9.0 for a job that does not exhibit this behavior:

bash-4.4$ cd /tmp/awx_29_gzj9pk0v/artifacts/29/
bash-4.4$ pwd
^M
PLAY [Hello World Sample] ******************************************************
^M
TASK [Gathering Facts] *********************************************************
^[[0;32mok: [localhost]^[[0m
^M
TASK [Hello Message] ***********************************************************
^[[0;32mok: [localhost] => {^[[0m^M
^[[0;32m    "msg": "Hello World!"^[[0m^M
^[[0;32m}^[[0m
^M
PLAY RECAP *********************************************************************^M
^[[0;32mlocalhost^[[0m                  : ^[[0;32mok=2   ^[[0m changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   ^M

[ryanpetrello]

I think this change is responsible for the regression:

ansible/ansible#65199

If I install 2.9.6, I see the behavior. If I edit my ansible 2.9.6 source code and undo that change, the problem goes away.

cc @samdoran

[ryanpetrello]

@ryan012880 I've opened a PR to roll back this change to ansible, in case you want to give it a whirl:

ansible/ansible#68375

[ryan012880]

@ryan012880,

Are you running 9.3.0, or devel (with the new redis changes)?

running devel

[ryan012880]

@ryan012880 I've opened a PR to roll back this change to ansible, in case you want to give it a whirl:

ansible/ansible#68375

@ryanpetrello noted, thank you

[ryanpetrello]

New approach to address this in Ansible, courtesy of @ghjm:

ansible/ansible#68375

[ryanpetrello]

This will be resolved in the next version of Ansible (and I believe it's being backported to the next 2.9.x). Until then, it looks like older versions of 2.9.x don't have this issue:

ansible/ansible#68517

[ghjm]

ansible/ansible#68517 is merged into Ansible devel. The 2.9 backport,
ansible/ansible#68520, will be reviewed at the next backport review, and is expected to land before the next Ansible 2.9.x release.

[squidboylan]

I confirmed that devel and ansible/ansible#68520 both work using a custom_virtualenv for a job template

[dsesami]

@squidboylan mentioned that this is waiting on ansible/ansible#68520 to merge. @ryanpetrello

[ryanpetrello]

@one-t @squidboylan @dsesami the relevant Ansible change was merged into the 2.9 branch and this is ready for verification.

[squidboylan]

I just tested this with 3 hosts in an inventory using latest 2.9 and it worked as expected

[ryan012880]

I can confirm also all is good thank you.