-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.9] CVE-2020-1746 - Remove the params module option from ldap_attr and ldap_entry #68714
Merged
mattclay
merged 4 commits into
ansible:stable-2.9
from
s-hertel:2.9-community.general.ldap_params_fix
Apr 15, 2020
Merged
[2.9] CVE-2020-1746 - Remove the params module option from ldap_attr and ldap_entry #68714
mattclay
merged 4 commits into
ansible:stable-2.9
from
s-hertel:2.9-community.general.ldap_params_fix
Apr 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module options that circumvent Ansible's option handling were disallowed in: https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html Additionally, this particular usage can be insecure if bind_pw is set this way as the password could end up in a logfile or displayed on stdout. Fixes CVE-2020-1746 (cherry picked from commit 0ff609f)
Co-Authored-By: Felix Fontein <felix@fontein.de>
ansibot
added
affects_2.9
This issue/PR affects Ansible v2.9
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
docs
This issue/PR relates to or includes documentation.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
net_tools
Net-tools category
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
labels
Apr 6, 2020
abadger
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me +1
ansibot
removed
the
needs_triage
Needs a first human triage before being processed.
label
Apr 6, 2020
bcoca
added
the
P1
Priority 1 - Immediate Attention Required; Release Immediately After Fixed
label
Apr 6, 2020
felixfontein
suggested changes
Apr 7, 2020
This was referenced Apr 7, 2020
s-hertel
force-pushed
the
2.9-community.general.ldap_params_fix
branch
from
April 9, 2020 18:43
2e485a0
to
6338e8f
Compare
felixfontein
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.9
This issue/PR affects Ansible v2.9
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
docs
This issue/PR relates to or includes documentation.
module
This issue/PR relates to a module.
net_tools
Net-tools category
P1
Priority 1 - Immediate Attention Required; Release Immediately After Fixed
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Based on #67866
Updated in community.general in ansible-collections/community.general#113
Fix for CVE-2020-1746
Module options that circumvent Ansible's option handling were disallowed
in:
https://meetbot.fedoraproject.org/ansible-meeting/2017-09-28/ansible_dev_meeting.2017-09-28-15.00.log.html
Additionally, this particular usage can be insecure if bind_pw is set
this way as the password could end up in a logfile or displayed on
stdout.
Backport of ansible-collections/community.general#113
ISSUE TYPE
COMPONENT NAME