Fix up the redirection of the win setup module #70158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
nitzmahone
approved these changes
Jun 19, 2020
|
Yep, that's the right thing to do. I noticed the issue awhile back and mistakenly suffixed source and target instead of prefacing all the sources, then it just got lost in the shuffle with the other masses of changes. Thanks for the fix. |
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Jun 19, 2020
(cherry picked from commit 8b24a4c)
|
Thanks for confirming/merging @nitzmahone Backport PR to stable-2.10 #70181 |
nitzmahone
pushed a commit
that referenced
this pull request
Jun 20, 2020
mkrizek
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The setup module for Windows has the extension in the redirected module path which caused the failure
By removing the extension it is properly redirected to the ansible.windows collection. This also adds the
.ps1extensions to the windows slurp and async_status redirection entries (not the target) to ensure they are only chosen over the Python async_status/slrup module if the user targets a Windows host.ISSUE TYPE
COMPONENT NAME
setup