Reduce ignored module sanity tests #70319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
samdoran
removed
the
needs_triage
ansibot
added
needs_rebase
Akasurde
requested changes
Jul 2, 2020
There was a problem hiding this comment.
@aminvakil Thanks for the contribution. Could you please rebase and apply the suggestions? @Andersson007 @felixfontein Could you please review as well? Thanks in advance.
|
@aminvakil Could you please rebase using https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html#rebasing-a-pull-request? |
aminvakil
changed the title
Akasurde
reviewed
Jul 2, 2020
ansibot
added
WIP
aminvakil
changed the title
ansibot
removed
the
WIP
added 25 commits
September 18, 2020 15:32
s-hertel
reviewed
Sep 22, 2020
|
@felixfontein @Andersson007 @Akasurde @bmillemathias @s-hertel @samdoran Thanks for reviewing! |
heiderich
pushed a commit
to heiderich/ansible
that referenced
this pull request
Oct 4, 2020
* Reorder test/sanity/ignore.txt to better see changes * Remove extra empty line causing pass fail * Apply suggestions made by Akasurde * Minor fix in package_facts and remove two unnecessary ignores * Fix subversion based on a suggestion made by felixfontein * Apply suggestions made by felixfontein and Andersson007 * Fix subversion.py as suggested by felixfontein * Minor reformatting in yum_repository description * Reformat changelog * Add key to apt_key, add deprecated changelog * Add PR url to changelog * Ignore paramater-type-not-in-doc in favour of adding key back to apt_key * Fix apt_key * Remove undocumented-paramater from apt_key ignore * Ignore doc-choices-do-not-match-spec in package_facts * Fix package_facts * Fix filter option in setup module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Trying to reduce ignores from module sanity tests as possible as I can.
ISSUE TYPE
COMPONENT NAME
collection