Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure -k is set to delegated hosts without a pass (#71136) - 2.10 #71168

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Ensure -k is set to delegated hosts without a pass (#71136) - 2.10 #71168

merged 1 commit into from
Aug 27, 2020

Conversation

jborean93
Copy link
Contributor

(cherry picked from commit 3f22f79)

SUMMARY

Backport of #71136

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/config/manager.py

@jborean93
Ensure -k is set to delegated hosts without a pass (ansible#71136)
bd05df5 
* Ensure -k is set to delegated hosts without a pass

* Fix up some broken tests

* Update task_executor.py

one possible fix, the other is updating winrm to normalize on 'password' like the other connection plugins

* Add alias for winrm and fix incorrect assumption

* Make sure aliases are used for keyword options

* Conditionally run test if sshpass is present, fix sanity

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
(cherry picked from commit 3f22f79)
@jborean93 jborean93 mentioned this pull request Aug 7, 2020
Merged
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 7, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 16, 2020
@relrod relrod merged commit 092ec68 into ansible:stable-2.10 Aug 27, 2020
@jborean93 jborean93 deleted the delegation_ask_pass-2.10 branch August 27, 2020 18:37
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 27, 2020
@ansible ansible locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jborean93 @sivel @relrod @ansibot