Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport][2.9] vmware_guest: Add support for HW version 15 (vSphere 6.7U2) #71565

Merged
merged 2 commits into from Sep 27, 2020
Merged

[backport][2.9] vmware_guest: Add support for HW version 15 (vSphere 6.7U2) #71565

merged 2 commits into from Sep 27, 2020

Conversation

mariolenz
Copy link
Contributor

SUMMARY

We need to deploy VMs with HW version 15 (vSphere 6.7U2) but ansible 2.9 doesn't support this; 2.10 does but isn't stable yet.

Fixes #71563, backport of VMware collection ansible-collections/community.vmware#99

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

vSphere 6.7U2 isn't that new, latest versions are 6.7U3 and 7.0.

@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2020

@mariolenz, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. cloud collection Related to Ansible Collections work collection:community.vmware community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Sep 1, 2020
@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2020

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/71563-vmware_guest-support_hw_version_15.yml:0:0: section "minor_changes" list items must be type str not dict

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 1, 2020
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 1, 2020
@mariolenz @Akasurde
Update changelogs/fragments/71563-vmware_guest-support_hw_version_15.yml
66c4f86 
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 2, 2020
@mariolenz
Copy link
Contributor Author

recheck

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 2, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 10, 2020
@mariolenz
Copy link
Contributor Author

recheck

@mariolenz
Copy link
Contributor Author

/rebuild

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 16, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 26, 2020
@relrod
Copy link
Member

relrod commented Sep 27, 2020

/rebuild

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 27, 2020
@relrod relrod merged commit d2b499e into ansible:stable-2.9 Sep 27, 2020
@mariolenz mariolenz deleted the 71563 branch September 27, 2020 18:29
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 29, 2020
@ansible ansible locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. cloud collection:community.vmware collection Related to Ansible Collections work community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mariolenz @ansibot @relrod @Akasurde @sivel