Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Playbook and PlaybookInclude into parent chain #73309

Draft
wants to merge 34 commits into
base: devel
Choose a base branch
from
Draft

Add Playbook and PlaybookInclude into parent chain #73309

wants to merge 34 commits into from
+312 −151

Conversation

sivel
Copy link
Member

@sivel sivel commented Jan 20, 2021 •
edited

SUMMARY

Add Playbook and PlaybookInclude into parent chain

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Checklist

  • Ensure block reparenting works. Stop at Play?
  • Prefer and allow vars/ for vars_files
  • Multiple static role parents, like a diamond of import_role in roles...
    • I'm not sure this is a concern, static roles are always children of the play, regardless of their structure

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 20, 2021
@ansibot
Copy link
Contributor

ansibot commented Jan 20, 2021

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/playbook/play.py:299:5: E303: too many blank lines (2)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 20, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jan 20, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 20, 2021
@ansibot
Copy link
Contributor

ansibot commented Jan 20, 2021

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/playbook/block.py:217:13: E722: do not use bare 'except'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 20, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jan 20, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 22, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Jan 22, 2021
@sivel sivel mentioned this pull request Jan 22, 2021
Closed
@ansibot ansibot added has_issue core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jan 22, 2021
@mkrizek
Copy link
Contributor

mkrizek commented Jan 25, 2021

!waffling core_review

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 25, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 2, 2021
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 18, 2021
@jbguerraz
Copy link

What's up with that PR ? is there any way to help moving it ahead ? (main concern is #36806)

@sivel
Copy link
Member Author

sivel commented Oct 29, 2021

What's up with that PR ? is there any way to help moving it ahead ? (main concern is #36806)

The biggest problem with this PR is actually vars_files. It is the one thing that I believe needs to fundamentally change before we can do this. Right now vars_files can contain host specific templating, which causes a number of problems.

@sivel sivel mentioned this pull request Jan 31, 2022
Closed
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 31, 2022
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 30, 2022
@ansibot ansibot removed the has_issue label Jul 12, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
@rndmh3ro rndmh3ro mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoca bcoca bcoca left review comments

Assignees
No one assigned
Labels
affects_2.11 feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sivel @ansibot @mkrizek @jbguerraz @bcoca @samdoran @s-hertel