Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block vars take precedence over parent #76888

Closed
wants to merge 2 commits into from
Closed

Block vars take precedence over parent #76888

wants to merge 2 commits into from

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jan 31, 2022

SUMMARY

Fixes #76883

ci_complete

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/playbook/block.py

@mkrizek mkrizek mentioned this pull request Jan 31, 2022
Closed
1 task
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.13 bug This issue/PR relates to a bug. has_issue needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 31, 2022
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jan 31, 2022
@sivel
Copy link
Member

sivel commented Jan 31, 2022

Duplicate of #75287

Although I don't think we ever got tests working there.

I also fixed this in #73309 with and made the following test changes:

https://github.com/ansible/ansible/pull/73309/files#diff-84f704ebed304b3d4e78336b1887e36f62d69e2d2061ffcf05d9b3717279e427
https://github.com/ansible/ansible/pull/73309/files#diff-8f7e3390567f85b0139b65b55a81ecb6c024a4c65081013088c5d20c7ac712b9

@mkrizek mkrizek closed this Jan 31, 2022
@mkrizek mkrizek deleted the issue-76883 branch January 31, 2022 14:49
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 1, 2022
@ansible ansible locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.13 bug This issue/PR relates to a bug. has_issue small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vars in nested blocks not overwrite vars in upper blocks
3 participants
@mkrizek @sivel @ansibot