Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[security] Add no_log to several module args (CVE-2021-20191) [2.8] #73488

Merged
merged 3 commits into from Feb 5, 2021
Merged

[security] Add no_log to several module args (CVE-2021-20191) [2.8] #73488

merged 3 commits into from Feb 5, 2021

Conversation

relrod
Copy link
Member

@relrod relrod commented Feb 4, 2021

SUMMARY

Change:

  • A number of modules were missing no_log=True where they should have
    had it.

Test Plan:

  • Lots of grepping.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules

@relrod
[security] Add no_log to several module args
ab215a6 
Change:
- A number of modules were missing no_log=True where they should have
  had it.

Test Plan:
- Lots of grepping.
@ansibot
Copy link
Contributor

ansibot commented Feb 4, 2021

@relrod, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies cloud collection Related to Ansible Collections work collection:cisco.nxos collection:community.docker collection:community.general collection:community.network collection:google.cloud collection:netapp.elementsw community_review In order to be merged, this PR must follow the community review workflow. deprecated This issue/PR relates to a deprecated module. docker gce huawei Huawei community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp networking Network category nxos Cisco NXOS community storage support:community This issue/PR relates to code supported by the Ansible community. web_infrastructure Web-infrastructure category labels Feb 4, 2021
@ansibot
Copy link
Contributor

ansibot commented Feb 4, 2021

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/google/gcp_compute_backend_service.py:689:161: E501 line too long (173 > 160 characters)
lib/ansible/modules/cloud/google/gcp_compute_instance_template.py:866:161: E501 line too long (168 > 160 characters)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 4, 2021
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 4, 2021
@relrod
lint
0792ad5 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Add a bunch of missing ones. Ref: ansible-collections/community.gener…
75ea5a3 
…al#1725

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. gitlab Gitlab community infoblox Infoblox NIOS monitoring Monitoring category net_tools Net-tools category packaging Packaging category source_control Source-control category support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 4, 2021
@relrod relrod merged commit cc82d98 into ansible:stable-2.8 Feb 5, 2021
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2021
@ansible ansible locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies cloud collection:cisco.nxos collection:community.docker collection:community.general collection:community.network collection:google.cloud collection:netapp.elementsw collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. docker gce gitlab Gitlab community huawei Huawei community infoblox Infoblox NIOS module This issue/PR relates to a module. monitoring Monitoring category net_tools Net-tools category netapp networking Network category nxos Cisco NXOS community packaging Packaging category source_control Source-control category storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. web_infrastructure Web-infrastructure category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@relrod @ansibot @sivel