Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no_log mask suboption fallback values and defaults CVE-2021-20228 - 2.9 #73493

Merged
merged 1 commit into from Feb 7, 2021
Merged

no_log mask suboption fallback values and defaults CVE-2021-20228 - 2.9 #73493

merged 1 commit into from Feb 7, 2021

Conversation

jborean93
Copy link
Contributor

(cherry picked from commit 0cdc410)

SUMMARY

Backport of #73487

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

basic.py

@jborean93 jborean93 mentioned this pull request Feb 4, 2021
Merged
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 4, 2021
@jborean93
Copy link
Contributor Author

It looks like the centos 6 failure is unrelated to this PR and potentailly something already broken in that branch.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Feb 5, 2021
@relrod
Copy link
Member

relrod commented Feb 5, 2021

CI failures likely related to #73476.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Feb 5, 2021
@samdoran
Copy link
Contributor

samdoran commented Feb 5, 2021 •
edited

CI failures are due to rpm-build being removed by setup_mysql_db. Fixed in #73516.

@jborean93 @relrod
no_log mask suboption fallback values and defaults CVE-2021-20228 (an…
c9fbf16 
…sible#73487)

* no_log mask suboption fallback values and defaults

* Added changelog

* Remove lambda expression

(cherry picked from commit 0cdc410)
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Feb 5, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 5, 2021
@relrod relrod merged commit 49ebd50 into ansible:stable-2.9 Feb 7, 2021
@jborean93 jborean93 deleted the nolog-suboptions-2.9 branch February 7, 2021 08:22
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2021
@ansible ansible locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jborean93 @relrod @samdoran @sivel @ansibot