pause action: catch more potential errors when setting up curses #73588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
mattclay
approved these changes
Feb 12, 2021
mattclay
removed
the
needs_triage
|
@mattclay thanks for reviewing and merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In certain very constraint situations,
curses.setupterm()can also raise anio.UnsupportedOperationexception:ERROR: lib/ansible/plugins/action/pause.py:47:0: traceback: UnsupportedOperation: fileno(seen in #72497).This makes sure that that error is also handled the same as other errors.
ISSUE TYPE
COMPONENT NAME
pause