Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distribution: Add Amazon Linux distribution facts #73767

Merged
merged 1 commit into from
Mar 5, 2021
Merged

distribution: Add Amazon Linux distribution facts #73767

merged 1 commit into from
Mar 5, 2021

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Mar 3, 2021

SUMMARY
  • Update Amazon Linux Distribution facts gathering logic
  • Update tests

Fixes: #73742

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/73742_amazon_distribution.yml
lib/ansible/module_utils/facts/system/distribution.py
test/units/module_utils/facts/system/distribution/fixtures/amazon_linux_2.json
test/units/module_utils/facts/system/distribution/fixtures/amazon_linux_2016.03.json
test/units/module_utils/facts/system/distribution/fixtures/amazon_linux_2018.03.json
test/units/module_utils/facts/system/distribution/fixtures/amazon_linux_2_karoo.json

@Akasurde
distribution: Add Amazon Linux distribution facts
560f29c 
* Update Amazon Linux Distribution facts gathering logic
* Update tests

Fixes: ansible#73742

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested a review from samdoran March 3, 2021 09:57
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 3, 2021
@Akasurde Akasurde added the distro_port Label for changes to distribution output due to the 2.8 port to the distro package label Mar 3, 2021
@Akasurde Akasurde mentioned this pull request Mar 3, 2021
Closed
@bcoca
Copy link
Member

bcoca commented Mar 4, 2021

have we checked that for previous amazon linux versions a os-release file won't contradict the old pathway?

@Akasurde
Copy link
Member Author

Akasurde commented Mar 5, 2021

have we checked that for previous amazon linux versions a os-release file won't contradict the old pathway?

Yes, Older version like Amazon Linux 2 and 2 (Karoo) is tested with this change and works fine. I also added tests for these distro.

@bcoca bcoca merged commit fb66b4f into ansible:devel Mar 5, 2021
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2021
@kbrahmbh
Copy link

kbrahmbh commented Mar 8, 2021

Is it possible backport the fix to ansible-2.8 and further?

@Akasurde Akasurde deleted the i73742 branch March 9, 2021 12:05
@Akasurde
Copy link
Member Author

Akasurde commented Mar 9, 2021

Ansible 2.8 is for critical security fixes. We can backport to 2.9 and 2.10. Please see https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html

@kbrahmbh
Copy link

kbrahmbh commented Mar 9, 2021

Thank you Abhijeet for your help. Yes, please lets back port it to 2.9 and 2.10 if not already done. I can upgrade my ansible to 2.9 and above. Thanks again for your help.

@Akasurde
Copy link
Member Author

Backport 2.9 - #73846
Backport 2.10 - #73845

@flowerysong flowerysong mentioned this pull request Mar 17, 2021
Closed
@ansible ansible locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran Awaiting requested review from samdoran

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. distro_port Label for changes to distribution output due to the 2.8 port to the distro package has_issue support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ansible_distribution_version fact does not return correct value for Amazon Linux
4 participants
@Akasurde @bcoca @kbrahmbh @ansibot