Pipe it to connections (#73688) #73914
Conversation
* pipelining tweaks added 'defaults' entry for ini pipelining from ssh plugin (cherry picked from commit 9690512)
ansibot
added
affects_2.10
ansibot
added
the
stale_ci
|
The fix is still not included in ansible-base 2.10.8. Could it be merged before 2.10.9? |
| - section: connection | ||
| - section: defaults | ||
| key: pipelining | ||
| - section: ssh_connection |
There was a problem hiding this comment.
Maybe ssh_connection should stay in the middle for 2.10, just in case someone had the setting specified there and working? I'm +1 for all the rest of the changes here for 2.10, but removing that ability in a bugfix patch might break some folks.
There was a problem hiding this comment.
@nitzmahone the same entries work in the plugin itself, this is not used so its just redundant
There was a problem hiding this comment.
Right, but a previous pipelining entry under ssh_connection would have enabled it globally (including for local), yeah? So changing that behavior in a backport patch is probably not the right thing...
There was a problem hiding this comment.
it still does for plugins that declare it, like paramiko, for most others it doesn't matter
There was a problem hiding this comment.
... and that makes total sense going forward, but removing the value in a backport is potentially introducing breaking behavior, because the existing behavior in those versions was global, not per-plugin. It's a corner case, but also one that's easily rectified by just leaving ssh_connection in the middle of the global mix for 2.10.
There was a problem hiding this comment.
i had checked back into even 2.9, no plugin used this directly
sivel
removed
the
needs_triage
added 'defaults' entry for ini pipelining from ssh plugin
(cherry picked from commit 9690512)
ISSUE TYPE
COMPONENT NAME
connection/*