Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remote user home expansion when user line ends #75011

Closed
wants to merge 4 commits into from
Closed

fix remote user home expansion when user line ends #75011

wants to merge 4 commits into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jun 15, 2021

line endings can appear in user names with domain\user
if user name startswith r or n

fixes #74957

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

action base

@bcoca
fix remote user home expansion when user line ends
98e2ef5 
   line endings can appear in user names with domain\user
   if user name startswith r or n

  fixes ansible#74957
@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 15, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 15, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 15, 2021
@ansible ansible deleted a comment from ansibot Jun 16, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 16, 2021
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Jun 16, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 17, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 29, 2021
@bcoca bcoca closed this May 25, 2022
@bcoca bcoca deleted the fix_domain_name_handling branch May 25, 2022 19:33
@ansible ansible locked and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local_action not compatible with some usernames
3 participants
@bcoca @ansibot @samdoran