Fix skeleton issue in user module #75152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.12
bug
Akasurde
reviewed
Jul 1, 2021
| @@ -1218,6 +1218,9 @@ def modify_user(self): | |||
|
|
|||
| def create_homedir(self, path): | |||
| if not os.path.exists(path): | |||
| if path == "/dev/null": | |||
There was a problem hiding this comment.
Please create a changelog fragment. See this fragment as an example. Also, write a test for this change here.
There was a problem hiding this comment.
this is changing detection on home dir not on skeleton (see a few lines below) also you will need to do this for more than just this version of create_homedir.
ansibot
added
needs_revision
ansibot
added
the
stale_ci
|
closing due to inactivity and #75948 seems to be closer to a mergable solution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #75063
ISSUE TYPE