Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.11] Improve handling of AnsibleModule arguments in validate-modules #75360

Merged
merged 2 commits into from
Aug 4, 2021
Merged

[2.11] Improve handling of AnsibleModule arguments in validate-modules #75360

merged 2 commits into from
Aug 4, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #75332 to stable-2.11.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

validate-modules

@felixfontein
Improve handling of AnsibleModule arguments in validate-modules (ansi…
cd81a42 
…ble#75332)

* Make sure AnsibleModule positional arguments are validated.

* Extract ANSIBLE_MODULE_CONSTURCTOR_ARGS with inspection.

* Remove no longer necessary return value.

* Fix PR #.

* argument_spec might not have been specified, as in community.general.xenserver_facts.

* Fix typo.

(cherry picked from commit 7726b70)
@ansibot ansibot added affects_2.11 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 29, 2021
@sivel
Copy link
Member

sivel commented Aug 4, 2021

This change exposes an issue with some modules and how AnsibleModule.__init__ is invoked. I'm working on a fix now.

@felixfontein
Copy link
Contributor Author

I included a backport of #75403.

@felixfontein felixfontein mentioned this pull request Aug 4, 2021
Merged
@sivel sivel merged commit e2f14d9 into ansible:stable-2.11 Aug 4, 2021
@felixfontein felixfontein deleted the backport/2.11/75332 branch August 5, 2021 05:57
@felixfontein
Copy link
Contributor Author

@sivel thanks for this one as well!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 5, 2021
@ansible ansible locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.11 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @sivel @ansibot