module_utils: Consolidate set_owner_if_different & set_group_if_different #75742
+41
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.12
core_review
moreati
force-pushed
the
chown-if-different
branch
from
7ec2820
to
25ee3d0
Compare
s-hertel
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
moreati
force-pushed
the
chown-if-different
branch
from
25ee3d0
to
68ab424
Compare
ansibot
added
needs_revision
|
/rebuild |
ansibot
added
core_review
ansibot
added
the
stale_ci
…rent This merges implementations of `AnsibleModule.set_owner_if_different()` & `AnsibleModule.set_group_if_different()` into a single method. The benefits are - reduction in code duplication - makes possible halving the number of calls to `os.lchown()` when the copy module sets both owner and group. There should be no outward change in behavior. The two original methods become thin wrappers around the new one. This PR is related to ansible#75741. If both are merged, then the second benefit above can be realised - by replacing calls in `copy.chown_recursive()`.
moreati
force-pushed
the
chown-if-different
branch
from
68ab424
to
d58ce51
Compare
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This merges implementations of
AnsibleModule.set_owner_if_different()&AnsibleModule.set_group_if_different()into a single method. The benefits areos.lchown()when the copy module sets both owner and group.There should be no outward change in behavior. The two original methods become thin wrappers around the new one.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
This PR is related to #75741. If both are merged, then the second benefit above can be realised - by replacing calls in
copy.chown_recursive().