ansible-test pslint - fix warning with nested objects #75792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.12
bug
nitzmahone
removed
the
needs_triage
|
@jborean93 Could a test case for this be added to the ansible-test integration tests? |
ansibot
added
the
stale_ci
|
I had a few minutes to look at this closer. Tests aren't feasible since our test containers don't use an affected version of PowerShell. Also, I tested this with PowerShell 7.1 and was able to reproduce the issue and confirmed the fix works. |
ansibot
removed
the
stale_ci
mattclay
approved these changes
Oct 7, 2021
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Oct 7, 2021
* ansible-test pslint - fix warning with nested objects (cherry picked from commit 7e19957)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Oct 7, 2021
* ansible-test pslint - fix warning with nested objects (cherry picked from commit 7e19957)
This was referenced Oct 7, 2021
mattclay
pushed a commit
that referenced
this pull request
Oct 7, 2021
* ansible-test pslint - fix warning with nested objects (cherry picked from commit 7e19957)
mattclay
pushed a commit
that referenced
this pull request
Oct 7, 2021
* ansible-test pslint - fix warning with nested objects (cherry picked from commit 7e19957)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some rules seem to output objects with a depth greater than 2. On some PowerShell versions
ConvertTo-Jsonwill emit a warning which stops the pipeline causing a failure rather than the validation error message. This PR will use a custom function to ensure the depth is not exceeded and to also add an explicit depth value just in case it does happen again.Fixes #74151
ISSUE TYPE
COMPONENT NAME
ansible-test