Skip to content

ansible-config get#75844

Draft
bcoca wants to merge 2 commits intoansible:develfrom
bcoca:config_get
Draft

ansible-config get#75844
bcoca wants to merge 2 commits intoansible:develfrom
bcoca:config_get

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented Sep 30, 2021

New action for ansilbe-config to "get" the value of a specific setting

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-config

@ansibot ansibot added affects_2.13 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 30, 2021
@ansibot

This comment has been minimized.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 30, 2021
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Sep 30, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 30, 2021
@ansibot

This comment has been minimized.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 30, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Oct 4, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Oct 5, 2021
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 17, 2021
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 29, 2021
@ansibot ansibot added has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 13, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 15, 2021
@ansibot
Copy link
Contributor

ansibot commented Dec 15, 2021

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/root/.ansible/test/venv/sanity.package-data/3.10/ed96082c/bin/python /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 401, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 378, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 185, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
Traceback (most recent call last):
  File "/tmp/tmpg1ruhi3o/hacking/build-ansible.py", line 103, in <module>
    main()
  File "/tmp/tmpg1ruhi3o/hacking/build-ansible.py", line 92, in main
    retval = command.main(args)
  File "/tmp/tmpg1ruhi3o/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
  File "/tmp/tmpg1ruhi3o/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 211, in opts_docs
    action_depth = get_actions(cli.parser, docs)
  File "/tmp/tmpg1ruhi3o/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 179, in get_actions
    action_info['desc'] = trim_docstring(getattr(cli, 'execute_%s' % action).__doc__)
AttributeError: 'ConfigCLI' object has no attribute 'execute_get'. Did you mean: 'execute_edit'?
make: *** [Makefile:147: generate_rst] Error 1

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/root/.ansible/test/venv/sanity.docs-build/3.10/3cd8b961/bin/python /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make core_singlehtmldocs' failed with status code: 2
--> Standard Output
Creating symlinks in core_structure
ln -sf ../rst/core_index.rst rst/index.rst
ln -sf ../sphinx_conf/core_conf.py rst/conf.py
../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/  ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/  ../../lib/ansible/config/base.yml
mkdir -p rst/cli
../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst  ../../lib/ansible/cli/*.py
--> Standard Error
Traceback (most recent call last):
  File "/root/ansible/docs/docsite/../../hacking/build-ansible.py", line 103, in <module>
    main()
  File "/root/ansible/docs/docsite/../../hacking/build-ansible.py", line 92, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 211, in opts_docs
    action_depth = get_actions(cli.parser, docs)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 179, in get_actions
    action_info['desc'] = trim_docstring(getattr(cli, 'execute_%s' % action).__doc__)
AttributeError: 'ConfigCLI' object has no attribute 'execute_get'. Did you mean: 'execute_edit'?
make: *** [Makefile:192: cli] Error 1

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 15, 2021
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 5, 2022
@ansibot
Copy link
Contributor

ansibot commented Jan 5, 2022

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/cli/config.py:546:0: trailing-newlines: Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/cli/config.py:486:5: E303: too many blank lines (2)
lib/ansible/cli/config.py:540:1: E302: expected 2 blank lines, found 1
lib/ansible/cli/config.py:546:1: W391: blank line at end of file

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 5, 2022
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 10, 2022
@bcoca bcoca marked this pull request as draft August 10, 2022 19:06
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 10, 2022
@ansibot ansibot removed the has_issue label Jul 12, 2023
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@ansibot
Copy link
Contributor

ansibot commented Jun 9, 2025

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/cli/config.py:137:54: E127: continuation line over-indented for visual indent
lib/ansible/cli/config.py:699:5: E303: too many blank lines (2)
lib/ansible/cli/config.py:753:1: E302: expected 2 blank lines, found 1
lib/ansible/cli/config.py:759:1: W391: blank line at end of file

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/cli/config.py:25:0: unused-import: Unused jsonify imported from ansible.module_utils.common.text.converters
lib/ansible/cli/config.py:759:0: trailing-newlines: Trailing newlines

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects_2.14 feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants