Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galaxy server config updates #77106

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Galaxy server config updates #77106

merged 5 commits into from
Jun 24, 2022

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Feb 22, 2022

also handle some corner cases with exceptions

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy

@bcoca bcoca mentioned this pull request Feb 22, 2022
Merged
@ansibot ansibot added affects_2.13 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 22, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 23, 2022
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 23, 2022
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Feb 24, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 24, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 24, 2022
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 4, 2022
s-hertel
s-hertel reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoca could you rebase this?

lib/ansible/cli/galaxy.py Outdated Show resolved Hide resolved
lib/ansible/cli/galaxy.py Outdated Show resolved Hide resolved
lib/ansible/cli/galaxy.py Show resolved Hide resolved
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 17, 2022
@bcoca bcoca force-pushed the galaxy_server_config_updates branch from 8d02a7d to d824320 Compare June 17, 2022 21:52
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 17, 2022
@bcoca bcoca force-pushed the galaxy_server_config_updates branch from e1c6238 to a632939 Compare June 17, 2022 22:59
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 23, 2022
@ansible ansible deleted a comment from ansibot Jun 23, 2022
@bcoca @s-hertel
ansible-galaxy configurable timeouts
157f097 
  - also fixed issues with precedence,
    so --ignore-certs now overrides config
  - made galaxy_timeout generic setting,
    if set, it becomes default for server configs,
    but now specific servers can override
  - updated tests or added notes (some tests ignore/override precedence)

Update lib/ansible/cli/galaxy.py

Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
@bcoca bcoca force-pushed the galaxy_server_config_updates branch from dcb8001 to 157f097 Compare June 23, 2022 16:50
@bcoca bcoca merged commit fa35aa4 into ansible:devel Jun 24, 2022
@bcoca bcoca deleted the galaxy_server_config_updates branch June 24, 2022 17:27
@ansible ansible locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@newswangerd newswangerd newswangerd left review comments

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.13 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bcoca @ansibot @newswangerd @s-hertel @mattclay @jborean93