Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-test - Improve container management. #78550

Merged
merged 84 commits into from
Nov 29, 2022
Merged

ansible-test - Improve container management. #78550

merged 84 commits into from
Nov 29, 2022

Conversation

mattclay
Copy link
Member

@mattclay mattclay commented Aug 15, 2022 •
edited
Loading

SUMMARY

ansible-test - Improve container management.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible-test

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.14 needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 15, 2022
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Aug 15, 2022
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Aug 16, 2022
@mattclay
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Aug 16, 2022
@mattclay
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 16, 2022
@mattclay mattclay force-pushed the at-container-testing branch 3 times, most recently from d431115 to c59cc3f Compare August 16, 2022 23:51
@webknjaz
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattclay mattclay force-pushed the at-container-testing branch 3 times, most recently from ba6d3f3 to d517b41 Compare August 18, 2022 01:23
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 18, 2022
@webknjaz
Copy link
Member

/azp run

@sivel sivel mentioned this pull request Nov 28, 2022
Closed
1 task
samccann
samccann approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs portion LGTM

@mattclay mattclay merged commit cda16cc into ansible:devel Nov 29, 2022
@mattclay mattclay deleted the at-container-testing branch November 29, 2022 21:35
@felixfontein
Copy link
Contributor

@mattclay and everyone else involved in this, thanks a lot for this huge improvement! :)

mattclay added a commit to mattclay/ansible that referenced this pull request Nov 29, 2022
@mattclay
[stable-2.14] ansible-test - Improve container management. (ansible#7…
f57931c 
…8550)

See changelogs/fragments/ansible-test-container-management.yml for details..
(cherry picked from commit cda16cc)

Co-authored-by: Matt Clay <matt@mystile.com>
This was referenced Nov 29, 2022
Merged
Closed
@briantist
Copy link
Contributor

@mattclay and everyone else involved in this, thanks a lot for this huge improvement! :)

big +1 :)

webknjaz
webknjaz reviewed Nov 30, 2022
View reviewed changes
test/lib/ansible_test/_internal/host_profiles.py
if 'Permission denied' in ex.message:
raise

# No "Permission denied" check is performed here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like timeouts still happen: #79508

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least we know it's not due to ansible-test trying to connect before the user is ready. It looks like we're back to needing to look over the logs on the guest when it's disconnecting the client.

This was referenced Nov 30, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@SphenicPaul SphenicPaul mentioned this pull request Dec 4, 2022
Closed
1 task
mattclay added a commit to mattclay/ansible that referenced this pull request Dec 6, 2022
@mattclay
ansible-test - Improve container management. (ansible#78550)
045a991 
See changelogs/fragments/ansible-test-container-management.yml for details.

(cherry picked from commit cda16cc)
@mattclay mattclay mentioned this pull request Dec 6, 2022
Merged
@ansible ansible locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz left review comments

@gotmax23 gotmax23 gotmax23 left review comments

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.14 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. feature This issue/PR relates to a feature request. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mattclay @webknjaz @felixfontein @briantist @ansibot @gotmax23 @samccann