Fix issue where using listen parameter for handlers in collections could lead to memory issues #83393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld lead to memory issues
ansibot
added
bug
|
@ShawnHardwick CI failures are known and being handled in a different PR. |
|
@Akasurde could you link to that PR? I'd like to follow it |
ansibot
added
the
needs_revision
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
removed
the
needs_revision
| @@ -558,7 +558,7 @@ def search_handlers_by_notification(self, notification: str, iterator: PlayItera | |||
| handler.fattributes.get('listen'), | |||
| listeners, | |||
| templar, | |||
| ) | |||
| ).copy() | |||
| if handler._role is not None: | |||
| for listener in listeners.copy(): | |||
There was a problem hiding this comment.
This second copy probably isn't needed anymore
There was a problem hiding this comment.
It is still needed as listeners are mutated within the for loop.
Closed
1 task
|
Superseded by #83400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where using
listenparameter for handlers in collections could lead to memory issues on Ansible controller.SUMMARY
Fixes #83392
ISSUE TYPE
ADDITIONAL INFORMATION
See issue for more info.