Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate and process Handler.listen only once #83400

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Validate and process Handler.listen only once #83400

merged 1 commit into from
Jun 10, 2024

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jun 7, 2024 •
edited
Loading

SUMMARY

Fixes #83392

ci_complete

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Jun 7, 2024
@mkrizek mkrizek mentioned this pull request Jun 7, 2024
Closed
1 task
@mkrizek mkrizek changed the title Handler._validate_listen() Validate and process Handler.listen only once Jun 10, 2024
@mkrizek mkrizek marked this pull request as ready for review June 10, 2024 14:50
@mkrizek mkrizek requested review from sivel, bcoca and s-hertel June 10, 2024 14:51
sivel
sivel approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@sivel sivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach a lot, as it removes extra work during execution. Tested and confirmed it is working as expected.

@sivel sivel merged commit cbbf068 into ansible:devel Jun 10, 2024
66 checks passed
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jun 10, 2024
@mkrizek
Validate and process Handler.listen only once (ansible#83400)
db1689a 
Fixes ansible#83392

(cherry picked from commit cbbf068)
This was referenced Jun 10, 2024
Merged
Closed
@mkrizek mkrizek deleted the issue-83392 branch June 10, 2024 15:55
sivel pushed a commit that referenced this pull request Jun 10, 2024
@mkrizek
Validate and process Handler.listen only once (#83400) (#83405)
b15c684 
Fixes #83392

(cherry picked from commit cbbf068)
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 10, 2024
@ansible ansible locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

@bcoca bcoca bcoca approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. has_issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible controller exponential memory usage when using handler listeners in collection
5 participants
@mkrizek @sivel @bcoca @s-hertel @ansibot