Skip to content

Commit

Permalink
When applying Deployment wait up to (timeout * replicas)
Browse files Browse the repository at this point in the history
There are cases when having a new Deployment may be taking above the
default timeout of 120s.
For instance, when a Deployment has multiple replicas, and each replica
starts on a separate node, and the Deployment specifies new images, then
just pulling these new images for each replica may be taking above the
default timeout of 120s.

Having the default time multiplied by the number of replicas should
provide generally enough time for all replicas to start
  • Loading branch information
stanislav-zaprudskiy committed Feb 7, 2023
1 parent 234a10d commit e589ceb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions roles/installer/tasks/resources_configuration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@
apply: yes
definition: "{{ lookup('template', 'deployments/deployment.yaml.j2') }}"
wait: yes
wait_timeout: "{{ 120 * replicas or 120 }}"
register: this_deployment_result

- block:
Expand Down

0 comments on commit e589ceb

Please sign in to comment.