remove helm chart version from labels

[FlorianLaunay]

SUMMARY

Remove the Helm chart version from helm.sh/chart labels in all Helm templates.

Fixes #1057

ISSUE TYPE

• Bug, Docs Fix or other nominal change

ADDITIONAL INFORMATION

Including chart version in the matchLabel selector of the AWX deployment template causes problem during the helm upgrade of the AWX operator. Indeed this field is now immutable for deployments in recent versions of Kubernetes (https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates). So running a helm upgrade with a chart containing a deployment template with a different content in the spec.selector.matchLabels field is not allowed and causes an error.

An acceptable solution when using kustomize is to remove chart version in labels. This will allow to continue to adhere to Helm best practices by having a relationship between metadata.labels and selector.matchLabels fields.

Tested on devel with make helm-chart and executing multiple helm upgrade

[rooftopcellist]

@miles-w-3 do you mind taking a look at this? If you are OK with this change, I can merge.

[miles-w-3]

I would be in favor of changing the label to just be the chart name rather than including the version, but it is not a functionality blocker to remove it. Generally, the helm.sh/chart is a nice way to get all resources deployed from a helm chart through kubectl. However, this label isn't present on the custom resources so we're currently not supporting it anyway.

I'm fine with removing it altogether, but maybe the best compromise would be to put just

helm.sh/chart: awx-operator

on all chart resources.

[rooftopcellist]

@FlorianLaunay what do you think about the approach of changing the label?

[FlorianLaunay]

@miles-w-3 @rooftopcellist TBH I hadn't thought about just removing the version in all labels 😇 but this is also fine for me. This will allow to continue to adhere to Helm best practices by having a relationship between metadata.labels and selector.matchLabels fields.
Should I modify this PR or open a new one ?

[janorn]

Do it in this PR.

[FlorianLaunay]

Rebase and PR modification done

[rooftopcellist]

Thanks for the contribution @FlorianLaunay !